Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit 'warn' in Note box in crictl tasks page #25546

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Edit 'warn' in Note box in crictl tasks page #25546

merged 1 commit into from
Dec 22, 2020

Conversation

reylejano
Copy link
Member

Related to fix issue k/website 25504

Removed 'Warn:' after 'Note:' for page
https://kubernetes.io/docs/tasks/debug-application-cluster/crictl/

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 10, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Dec 10, 2020
@reylejano
Copy link
Member Author

/cc @sftim
I missed the 'Warn:' in the last PR which merged already
Removed the 'Warn:' in this PR

@netlify
Copy link

netlify bot commented Dec 10, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit cc7c015

https://deploy-preview-25546--kubernetes-io-master-staging.netlify.app

@reylejano
Copy link
Member Author

Here's the preview of the edited page:
https://deploy-preview-25546--kubernetes-io-master-staging.netlify.app/docs/tasks/debug-application-cluster/crictl/#example-crictl-commands

@SergeyKanzhelev
Copy link
Member

/lgtm
/cc @qiutongs

thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 717994716b8971c1ddd15766e97a06d7e2537350

sftim
sftim reviewed Dec 22, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/kind cleanup

Thanks!

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit fa2c834 into kubernetes:master Dec 22, 2020
@reylejano reylejano deleted the tasks-crictl branch January 18, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@feiskyer feiskyer Awaiting requested review from feiskyer

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@qiutongs qiutongs Awaiting requested review from qiutongs

Assignees

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reylejano @SergeyKanzhelev @k8s-ci-robot @sftim