Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update access-cluster.md #25623

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Update access-cluster.md #25623

merged 1 commit into from
Dec 18, 2020

Conversation

guzj11
Copy link
Contributor

@guzj11 guzj11 commented Dec 15, 2020

sync with english version.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 15, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Dec 15, 2020
@netlify
Copy link

netlify bot commented Dec 15, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 04986e7

https://deploy-preview-25623--kubernetes-io-master-staging.netlify.app

sync with english version.

Apply suggestions from code review

Co-authored-by: Qiming Teng <[email protected]>
@tengqm
Copy link
Contributor

tengqm commented Dec 15, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ed808478de36213f517f92347ef93e9920d59d9c

@guzj11
Copy link
Contributor Author

guzj11 commented Dec 16, 2020

/lgtm

can we merge this commit?

Copy link

@markthink markthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@tengqm
Copy link
Contributor

tengqm commented Dec 18, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markthink, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit b9990dc into kubernetes:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants