Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh] Update service.md to fix some wrongs. #25697

Merged
merged 1 commit into from
Dec 26, 2020
Merged

[zh] Update service.md to fix some wrongs. #25697

merged 1 commit into from
Dec 26, 2020

Conversation

yuandongx
Copy link
Contributor

@yuandongx yuandongx commented Dec 18, 2020 •
edited
Loading

I think the ZH is incorrect translation about this line, so update it.

EN:

To learn about other ways to define Service endpoints, see Services without selectors.

ZH should be:

要了解定义服务端点的其他方法，请参阅[不带选择算符的服务]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 18, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 18, 2020
@yuandongx
Copy link
Contributor Author

/assign @tengqm

@netlify
Copy link

netlify bot commented Dec 18, 2020 •
edited
Loading

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: db55c7c

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5fe00c76b170d100070d3d24

😎 Browse the preview: https://deploy-preview-25697--kubernetes-io-master-staging.netlify.app

@howieyuen
Copy link
Member

/lgtm

@tengqm
Copy link
Contributor

tengqm commented Dec 18, 2020

/hold

This page is out of sync, please resync and then fix the typo.

./scripts/lsync.sh content/zh/docs/concepts/services-networking/service.md

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 67dd62518dbf9ddafc454d58088beb433ab1fedc

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2020
tengqm
tengqm reviewed Dec 18, 2020
View reviewed changes
content/zh/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
tengqm
tengqm reviewed Dec 18, 2020
View reviewed changes
content/zh/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/zh/docs/concepts/services-networking/service.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 21, 2020
@tengqm
Copy link
Contributor

tengqm commented Dec 21, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 939c264a33e0d539ecdead6747e5b365731a57a2

@yuandongx
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2020
@yuandongx
Copy link
Contributor Author

yuandongx commented Dec 21, 2020 •
edited
Loading

/cc @howieyuen

@howieyuen
Copy link
Member

/lgtm

@tengqm
Copy link
Contributor

tengqm commented Dec 21, 2020

/hold cancel

@yuandongx
Copy link
Contributor Author

yuandongx commented Dec 22, 2020 •
edited
Loading

@tengqm
It seems that two lgtm labels doesn't merge the PR.
If a approve is required ?

@tengqm
Copy link
Contributor

tengqm commented Dec 22, 2020

@yuandongx pls be patient.

tanjunchen
tanjunchen reviewed Dec 26, 2020
View reviewed changes
Copy link
Member

@tanjunchen tanjunchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit a7ce937 into kubernetes:master Dec 26, 2020
@yuandongx yuandongx deleted the patch-1 branch December 28, 2020 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanjunchen tanjunchen tanjunchen left review comments

@chenrui333 chenrui333 Awaiting requested review from chenrui333

@howieyuen howieyuen Awaiting requested review from howieyuen

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@tengqm tengqm

@howieyuen howieyuen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yuandongx @howieyuen @tengqm @k8s-ci-robot @tanjunchen