Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh]update health-checks.md. #25801

Merged
merged 1 commit into from
Dec 29, 2020
Merged

[zh]update health-checks.md. #25801

merged 1 commit into from
Dec 29, 2020

Conversation

yuandongx
Copy link
Contributor

Just formate changed.

/assign @howieyuen
/assign @tengqm

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 24, 2020
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 24, 2020
@netlify
Copy link

netlify bot commented Dec 24, 2020

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: 1962f7d

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5fe997fa613ffa0007184104

😎 Browse the preview: https://deploy-preview-25801--kubernetes-io-master-staging.netlify.app

@howieyuen
Copy link
Member

so indents can also be translated to code blocks?
@tengqm

@tengqm
Copy link
Contributor

tengqm commented Dec 24, 2020

This is an invalid fix.
The correct fix is to change the shell to none or just remove it.

@howieyuen Yes. Indentation by 4 spaces will be treated as implicit code blocks, which is a practice we discourage.

@yuandongx
Copy link
Contributor Author

yuandongx commented Dec 25, 2020

@tengqm @howieyuen
I just keep the format of Chinese and English consistent.
I'll close the PR, if you think it's not ok.
image

@tengqm
Copy link
Contributor

tengqm commented Dec 25, 2020

@yuandongx Pls do as I suggested, remove 'shell' from the code fence. That is all we need.

@xichengliudui
Copy link
Contributor

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Dec 25, 2020
@k8s-ci-robot
Copy link
Contributor

@xichengliudui: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xichengliudui
Copy link
Contributor

@yuandongx Pls do as I suggested, remove 'shell' from the code fence. That is all we need.

+1

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 28, 2020
@tengqm
Copy link
Contributor

tengqm commented Dec 28, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b7e73a2a1a8243a866da584bbd2dae562443a589

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 28, 2020
@xichengliudui
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xichengliudui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5744728 into kubernetes:master Dec 29, 2020
@yuandongx yuandongx deleted the h-check branch December 30, 2020 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants