Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfigure Kubelet: Update kubelet config link #25893

Merged

Conversation

surajssd
Copy link
Member

The old link points to the code base of 1.11. Since then there have been
several changes to the configuration, either new flags added or removed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 31, 2020
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Dec 31, 2020
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 31, 2020
@netlify
Copy link

netlify bot commented Dec 31, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 41de0de

https://deploy-preview-25893--kubernetes-io-master-staging.netlify.app

@tengqm
Copy link
Contributor

tengqm commented Jan 4, 2021

Also related to #23889

@sftim
Copy link
Contributor

sftim commented Jan 5, 2021

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jan 5, 2021
@bradtopol
Copy link
Contributor

Assigning @sftim since he is alrady engaged on this
/assign @sftim

@surajssd
Copy link
Member Author

Hey @sftim I have incorporated all the requested changes. PTAL.

@sftim
Copy link
Contributor

sftim commented Jan 22, 2021

I don't actually have the time to review this just now
/unassign

@tengqm
Copy link
Contributor

tengqm commented Jan 22, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2021
The old link points to the code base of 1.11. Since then there have been
several changes to the configuration, either new flags added or removed.

Signed-off-by: Suraj Deshmukh <[email protected]>
@surajssd
Copy link
Member Author

@SergeyKanzhelev done, PTAL.

Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e559ffc7d5b05dca3a0f44ae3bf2df639f739a9e

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 071e987 into kubernetes:master Feb 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SergeyKanzhelev, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@surajssd surajssd deleted the update-kubelet-config-link branch February 2, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants