Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud Controller Manager: fix a broken link #25914

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Cloud Controller Manager: fix a broken link #25914

merged 1 commit into from
Jan 4, 2021

Conversation

oke-py
Copy link
Contributor

@oke-py oke-py commented Jan 2, 2021

closes #25748

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Jan 2, 2021
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 2, 2021
@netlify
Copy link

netlify bot commented Jan 2, 2021

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: 89578d9

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5ff0484c9b9a8800076f88f6

😎 Browse the preview: https://deploy-preview-25914--kubernetes-io-master-staging.netlify.app

@oke-py
Copy link
Contributor Author

oke-py commented Jan 2, 2021

/assign @savitharaghunathan

@kbhawkey
Copy link
Contributor

kbhawkey commented Jan 2, 2021

Page preview:
https://deploy-preview-25914--kubernetes-io-master-staging.netlify.app/docs/tasks/administer-cluster/developing-cloud-controller-manager/

sftim
sftim reviewed Jan 2, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/sig api-machinery
/lgtm

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jan 2, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6e282f4836cb0c913aca0db3324a7bd38e0cf34d

@kbhawkey
Copy link
Contributor

kbhawkey commented Jan 4, 2021

Thanks for the update @oke-py .
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1ba6bf9 into kubernetes:master Jan 4, 2021
@oke-py oke-py deleted the 25748 branch January 4, 2021 19:21
@Arhell Arhell mentioned this pull request Jan 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@thockin thockin Awaiting requested review from thockin

@wlan0 wlan0 Awaiting requested review from wlan0

Assignees

@savitharaghunathan savitharaghunathan

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with k8s.io/docs/tasks/administer-cluster/developing-cloud-controller-manager/
5 participants
@oke-py @kbhawkey @k8s-ci-robot @sftim @savitharaghunathan