Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kubernetes project values to community page #26068

Merged
merged 1 commit into from
Feb 6, 2021
Merged

Add Kubernetes project values to community page #26068

merged 1 commit into from
Feb 6, 2021

Conversation

mrbobbytables
Copy link
Member

Our community values should be accessible on the user facing website. This PR adds them in a similar fashion to the Code of Conduct page.

/hold
For comment and review

/cc @cblecker @dims @derekwaynecarr @liggitt @nikhita @parispittman

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 13, 2021
mrbobbytables
mrbobbytables commented Jan 13, 2021
View reviewed changes
content/en/community/_index.html Outdated
Comment on lines 54 to 55
The Kubernetes Community values are the keystone to the ongoing success of the project.<br>
Their principals can be seen reflected in near every aspect or initiative within the Kubernetes project.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to change this wording, it's just what I could come up with for now^^:;;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

principals -> principles?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Kubernetes Community values are the keystone to the ongoing success of the project.<br>
Their principals can be seen reflected in near every aspect or initiative within the Kubernetes project.
These principles can already be seen reflected across many aspects or initiative within the Kubernetes project.

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to the edits

@netlify
Copy link

netlify bot commented Jan 13, 2021 •
edited
Loading

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: 09cdaac

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/6000f283f418a40008100242

😎 Browse the preview: https://deploy-preview-26068--kubernetes-io-master-staging.netlify.app

sftim
sftim reviewed Jan 13, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional tweaks

static/_redirects Outdated Show resolved Hide resolved
content/en/community/_index.html Outdated
Comment on lines 54 to 55
The Kubernetes Community values are the keystone to the ongoing success of the project.<br>
Their principals can be seen reflected in near every aspect or initiative within the Kubernetes project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Kubernetes Community values are the keystone to the ongoing success of the project.<br>
Their principals can be seen reflected in near every aspect or initiative within the Kubernetes project.
These principles can already be seen reflected across many aspects or initiative within the Kubernetes project.

?

@mrbobbytables
Copy link
Member Author

@sftim made that suggestion s/their/these
I think I honestly read that in my head originally heh

@liggitt
Copy link
Member

liggitt commented Jan 13, 2021

lgtm, I was surprised these weren't already on the community page

@derekwaynecarr
Copy link
Member

lgtm

@sftim
Copy link
Contributor

sftim commented Jan 13, 2021

/approve

Providing there are no objections, sufficient lazy consensus, and some active LGTM-ing, this is good to /lgtm and /unhold.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2021
@kbhawkey
Copy link
Contributor

Page previews:
https://deploy-preview-26068--kubernetes-io-master-staging.netlify.app/community/
https://deploy-preview-26068--kubernetes-io-master-staging.netlify.app/community/values/

@parispittman
Copy link
Contributor

lgtm

thanks bob!

@dims
Copy link
Member

dims commented Jan 13, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0f7b59b576b2b82116da06e2f0f7cd53a89496f2

zacharysarah
zacharysarah suggested changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrbobbytables 👋🏻 This is a helpful addition!

Some small fixes, otherwise LGTM

content/en/community/_index.html Outdated Show resolved Hide resolved
content/en/community/static/community-values.md
@@ -0,0 +1,28 @@
<!-- Do not edit this file directly. Get the latest from
Copy link
Contributor

@zacharysarah zacharysarah Jan 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See kubernetes/community#5408

Like the comment says, make changes upstream.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update once kubernetes/community#5411 is merged. 👍

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2021
irvifa
irvifa reviewed Feb 6, 2021
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks Bob!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6a4e2e75b9ae564dd56eb9288788f49a59e0958b

@irvifa
Copy link
Member

irvifa commented Feb 6, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6c6e697 into kubernetes:master Feb 6, 2021
@mrbobbytables mrbobbytables deleted the add-values branch February 2, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbhawkey kbhawkey kbhawkey left review comments

@irvifa irvifa irvifa left review comments

@sftim sftim sftim left review comments

@zacharysarah zacharysarah zacharysarah requested changes

@cblecker cblecker Awaiting requested review from cblecker

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@dims dims Awaiting requested review from dims

@liggitt liggitt Awaiting requested review from liggitt

@nikhita nikhita Awaiting requested review from nikhita

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@dims dims

@irvifa irvifa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mrbobbytables @liggitt @derekwaynecarr @sftim @k8s-ci-robot @kbhawkey @parispittman @dims @irvifa @zacharysarah