Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip crawling for new API documentation #26155

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Jan 19, 2021

Small change to lay the path for merging PR #23294. Approach as per #23294 (comment) but I tweaked it based on what I think provides broadest compatibility: I want to cover many search engines both current and not.

This prepares for the launch of new API documentation, initially without indexing by search engines.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 19, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 19, 2021
@netlify
Copy link

netlify bot commented Jan 19, 2021

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: ec8deb5

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/6007723cee14a00007fceb35

😎 Browse the preview: https://deploy-preview-26155--kubernetes-io-master-staging.netlify.app

@@ -6,4 +6,10 @@ Disallow: /v1.1/
Disallow: /404/
Disallow: /404.html

Allow: /docs/reference/generated/kubernetes-api/
Copy link
Contributor

@nate-double-u nate-double-u Jan 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this line the same (save for the disallow) as line 13? (allowing and then disallowing the same path)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Good spot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The disallow was originally Disallow: /docs/reference/generated/kubernetes-api/* and I amended it.

This prepares for the launch of new API documentation, initially without
indexing by search engines.
@sftim sftim force-pushed the 20210119_robots_txt_prepare_for_new_api_docs branch from 862a182 to ec8deb5 Compare January 19, 2021 23:58
@nate-double-u
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e7a5e8b54572c1031f3dd74846530b40b5988451

@zacharysarah
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8005676 into kubernetes:master Jan 20, 2021
@sftim sftim deleted the 20210119_robots_txt_prepare_for_new_api_docs branch January 20, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants