-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for v1.21 + indentation + local common definitions #26413
Conversation
/assign sftim |
/assign kbhawkey |
Deploy preview for kubernetes-io-master-staging ready! Built with commit a6c947a https://deploy-preview-26413--kubernetes-io-master-staging.netlify.app |
Hi @feloy . I am looking at the generated pages (and will read through the source changes). Some feedback:
A couple of page previews: Related to issue #25505. |
8d614e9
to
fecbe8d
Compare
I'm not sure of the implications. My idea is to wait for the definitive swagger definition of v1.21 before to merge this PR. The definitive swagger won't come before the Release Candidates probably.
Do you mean making redirections so links created in the actual pages are not broken when this PR is merged? As the pages are not crawled by robots, do you think it is necessary?
|
Re: Do you mean making redirections so links created in the actual pages are not broken when this PR is merged? As the pages are not crawled by robots, do you think it is necessary? -OK. That seems correct. |
fecbe8d
to
2e371e9
Compare
New version of the reference reflecting the changes in v1.21-beta.0
|
Hi @feloy . |
Hi @kbhawkey . I have based the PR on the dev-1.21 branch. I'll watch if there are any changes to the spec after the docs release. |
/milestone 1.21 |
Deploy preview for kubernetes-io-vnext-staging processing. Building with commit f7943d8 https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6066b8c981c09e000764b34e |
Hi @feloy, are the steps documented to prepare the API Reference documentation for 1.21? |
Hi @reylejano The process to prepare the API reference doc has been briefly described in the README.md file of this k/website repository (https://github.com/kubernetes/website/blob/master/README.md#building-the-api-reference-pages) and in the README of the generator (https://github.com/kubernetes-sigs/reference-docs/blob/master/gen-resourcesdocs/README.md). For the 1.21 release, all the needed work is included in this PR, so I think there is nothing to do more than merging it. For the next releases, adding more detailed information to the release docs role handbook would be nice. |
Hi @feloy . Do you want to keep the separate commits or rebase into one commit? /lgtm |
LGTM label has been added. Git tree hash: 815814db036247105751a830973c4e9a410de3ef
|
8fea4ca
to
f7943d8
Compare
Hi @kbhawkey Thanks for the review. I just squashed my commits |
Feel free to unhold when the time comes |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irvifa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @irvifa |
Preview at https://deploy-preview-26413--kubernetes-io-master-staging.netlify.app/docs/reference/kubernetes-api/
Prepares the API Reference documentation for v1.21
Moves some Definitions from Common Definitions page to specific page (ex Handler, NodeAffinity, etc moved to Pod page).
Enables deep indentation for nested fields.
Pages generated by kubernetes-sigs/reference-docs#207