Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove command from output block #26453

Merged
merged 1 commit into from
Feb 10, 2021
Merged

remove command from output block #26453

merged 1 commit into from
Feb 10, 2021

Conversation

oke-py
Copy link
Contributor

@oke-py oke-py commented Feb 10, 2021

This line does not meet "Separate commands from output" style guide.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 10, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2021
@netlify
Copy link

netlify bot commented Feb 10, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit a1f5566

https://deploy-preview-26453--kubernetes-io-master-staging.netlify.app

@tengqm
Copy link
Contributor

tengqm commented Feb 10, 2021

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 79061b5453df585a469bff2b67bfa8b54336e629

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit ca018cf into kubernetes:master Feb 10, 2021
@oke-py oke-py deleted the style branch February 10, 2021 13:39
This was referenced Mar 25, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daminisatya daminisatya Awaiting requested review from daminisatya

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oke-py @tengqm @k8s-ci-robot