fixed some typos and grammatical mistakes #26474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
language/en
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 0c7f918 https://deploy-preview-26474--kubernetes-io-master-staging.netlify.app |
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
irvifa
suggested changes
Feb 12, 2021
kbhawkey
reviewed
Feb 12, 2021
| Kubernetes API. To manually create a service account, use the `kubectl | ||
|
|
||
| can be used to create identities for long-standing jobs that wish to talk to the | ||
| Kubernetes API. To manually create a service account, simply use the `kubectl |
There was a problem hiding this comment.
This change is not needed.
kbhawkey
reviewed
Feb 12, 2021
| @@ -101,7 +101,7 @@ If Bob makes a request to write (`create` or `update`) to the objects in the `pr | |||
|
|
|||
| Kubernetes authorization requires that you use common REST attributes to interact with existing organization-wide or cloud-provider-wide access control systems. It is important to use REST formatting because these control systems might interact with other APIs besides the Kubernetes API. | |||
|
|
|||
| Kubernetes supports multiple authorization modules, such as ABAC mode, RBAC Mode, and Webhook mode. When an administrator creates a cluster, they configure the authorization modules that should be used in the API server. If more than one authorization modules are configured, Kubernetes checks each module, and if any module authorizes the request, then the request can proceed. If all of the modules deny the request, then the request is denied (HTTP status code 403). | |||
| Kubernetes supports multiple authorization modules, such as ABAC mode, RBAC Mode, and Webhook mode. When an administrator creates a cluster, they configure the authorization modules that should be used in the API server. If more than one authorization modules are configured, Kubernetes checks each module, and if any module authorizes the request, then the request can proceed. If all the modules deny the request, then the request is denied (HTTP status code 403). | |||
There was a problem hiding this comment.
Why did you remove the “of” here? I don’t understand
Co-authored-by: Irvi Aini <[email protected]>
Co-authored-by: Irvi Aini <[email protected]>
irvifa
suggested changes
Feb 13, 2021
| Kubernetes API. To manually create a service account, use the `kubectl | ||
|
|
||
| can be used to create identities for long-standing jobs that wish to talk to the | ||
| Kubernetes API. To manually create a service account, simply use the `kubectl |
| @@ -101,7 +101,7 @@ If Bob makes a request to write (`create` or `update`) to the objects in the `pr | |||
|
|
|||
| Kubernetes authorization requires that you use common REST attributes to interact with existing organization-wide or cloud-provider-wide access control systems. It is important to use REST formatting because these control systems might interact with other APIs besides the Kubernetes API. | |||
|
|
|||
| Kubernetes supports multiple authorization modules, such as ABAC mode, RBAC Mode, and Webhook mode. When an administrator creates a cluster, they configure the authorization modules that should be used in the API server. If more than one authorization modules are configured, Kubernetes checks each module, and if any module authorizes the request, then the request can proceed. If all of the modules deny the request, then the request is denied (HTTP status code 403). | |||
| Kubernetes supports multiple authorization modules, such as ABAC mode, RBAC Mode, and Webhook mode. When an administrator creates a cluster, they configure the authorization modules that should be used in the API server. If more than one authorization modules are configured, Kubernetes checks each module, and if any module authorizes the request, then the request can proceed. If all the modules deny the request, then the request is denied (HTTP status code 403). | |||
There was a problem hiding this comment.
Why did you remove the “of” here? I don’t understand
|
@shahincsejnu both I and @kbhawkey had comments on your PR why dis you resolve that? |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c83b64a1d6d6632d6dfa71701126742ed3d41aab
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irvifa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.