Remove feature-state tag for categories for CRDs #26932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Categories field for CRDs was documented as beta in 1.10 in kubernetes#7439 mainly because CRDs were in beta back then. The `feature-state` tag for this section was added in kubernetes#2754, however this section doesn't need a `feature-state` tag because the field is not gated by any feature gate: https://github.com/kubernetes/kubernetes/blob/90851a0fb5bbb6f02b3c22715f9f91609f8ee438/staging/src/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1/types.go#L247-L251 It is now safe to remove the feature-state tag. Moreover, CRDs are now GA so the beta state is not accurate.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
language/en
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit e5a1775 https://deploy-preview-26932--kubernetes-io-master-staging.netlify.app |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/assign @roycaihw |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 38eb699e5c4342efa44030daceefe9d8de9297df
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Categoriesfield for CRDs was documented as beta in 1.10 in #7439mainly because CRDs were in beta back then.
The
feature-statetag for this section was added in #2754, howeverthis section doesn't need a
feature-statetag because the field is notgated by any feature gate:
https://github.com/kubernetes/kubernetes/blob/90851a0fb5bbb6f02b3c22715f9f91609f8ee438/staging/src/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1/types.go#L247-L251
It is now safe to remove the feature-state tag. Moreover, CRDs are now
GA so the beta state is not accurate.
/assign @sftim