Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy docs about EndpointSlice & related features #27390

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Apr 3, 2021

Tidy docs in relation to SIG Network v1.21 feature changes (EndpointSlice graduation to GA, ServiceTopology feature deprecation, TopologyAwareHints alpha).

Follows on from PRs:

/milestone 1.21
/sig network
/kind cleanup
/language en

@sftim sftim requested review from robscott and maplain April 3, 2021 15:18
@k8s-ci-robot k8s-ci-robot added this to the 1.21 milestone Apr 3, 2021
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Apr 3, 2021

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit c9ca131

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/606b24738f9db20008ae436a

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 3, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 3, 2021
@sftim sftim force-pushed the 20210403_tidy_service_endpoints_docs_1.21 branch from 6d62664 to 60cba5f Compare April 3, 2021 23:21
@reylejano
Copy link
Member

/assign

@sftim sftim force-pushed the 20210403_tidy_service_endpoints_docs_1.21 branch from b95355f to c9ca131 Compare April 5, 2021 14:53
@sftim
Copy link
Contributor Author

sftim commented Apr 5, 2021

@reylejano #27390 (comment) looks like I didn't fix things, but actually that's GitHub hiding that I did.

@reylejano
Copy link
Member

Thank you for cleaning up the docs
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 905b551174ef98b6a16637bde4c030201db67568

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit 029c885 into kubernetes:dev-1.21 Apr 5, 2021
@sftim sftim deleted the 20210403_tidy_service_endpoints_docs_1.21 branch June 9, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants