-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minor markdown issue in ServiceAccount docs #27509
Conversation
Fix minor issue in ServiceAccount docs.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @codedevote! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/signed |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 57d593e https://deploy-preview-27509--kubernetes-io-master-staging.netlify.app |
@@ -16,7 +16,10 @@ weight: 1 | |||
|
|||
## ServiceAccount {#ServiceAccount} | |||
|
|||
ServiceAccount binds together: * a name, understood by users, and perhaps by peripheral systems, for an identity * a principal that can be authenticated and authorized * a set of secrets | |||
ServiceAccount binds together: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @codedevote .
This content is auto-generated by the API reference generator.
/cc @feloy .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more info about CLA, check please
https://github.com/kubernetes/community/blob/master/CLA.md
I acutally signed the CLA 6 days ago. Maybe I didn't trigger the bot correctly. |
As it seems I may have missed a step, which I now finished. Should be fine now (hopefully). |
Hi @codedevote , this content is generated from the comments into the Kubernetes sources, changing this file won't have any effect as the changes will be overwritten the next time the files will be generated. For the moment, there is no way to correct this kind of Markdown issue (as the comments in the sources are not specifically in markdown format). |
Hi @feloy, ok, didn't know that. So I guess you can close this one. And just for future reference - is there a guide somewhere that would explain how to fix such minor documentation issues. It seems like I fell into the trap to believe that "Edit this page", (see screensot), which is available on every page in the docs, is actually the way to go... |
Hi @codedevote . Here is the front matter of a generated
|
@kbhawkey Yes, I'll add this attribute to the generated pages |
@kbhawkey I've added the Is this feature implemented or is it a work in progress? |
👋 @codedevote . |
@kbhawkey: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix minor issue in ServiceAccount docs.