Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise dynamic kubelet config task #30108

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Revise dynamic kubelet config task #30108

merged 2 commits into from
Dec 2, 2021

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Oct 16, 2021 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Oct 16, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 16, 2021
@netlify
Copy link

netlify bot commented Oct 16, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: c043aca

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61a276d13155a70007ddc03a

😎 Browse the preview: https://deploy-preview-30108--kubernetes-io-main-staging.netlify.app

RinkiyaKeDad
RinkiyaKeDad reviewed Nov 16, 2021
View reviewed changes
content/en/docs/tasks/administer-cluster/reconfigure-kubelet.md Outdated
Comment on lines 40 to 46
You also need kubectl v1.11 or higher, configured to communicate with your cluster.
{{< version-check >}}
Your cluster API server version (eg v1.12) must be no more than one minor
version away from the version of kubectl that you are using. For example,
if your cluster is running v1.16 then you can use kubectl v1.15, v1.16
or v1.17; other combinations
[aren't supported](/docs/setup/release/version-skew-policy/#kubectl).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Tim, are these constraints no longer valid? Otherwise the PR looks good to me 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We (currently) don't support Kubernetes older than v1.18 - see https://kubernetes.io/docs/home/supported-doc-versions/

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 17, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@sftim sftim force-pushed the 20211016_revise_dynamic_kubelet_config_task branch from 0f6c180 to cd0a519 Compare November 24, 2021 00:01
@sftim sftim force-pushed the 20211016_revise_dynamic_kubelet_config_task branch from cd0a519 to c043aca Compare November 27, 2021 18:20
@kbhawkey
Copy link
Contributor

kbhawkey commented Dec 2, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2021
mehabhalodiya
mehabhalodiya reviewed Dec 2, 2021
View reviewed changes
Copy link
Contributor

@mehabhalodiya mehabhalodiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
It's ready to merge!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bf32462ad3bfcead5bee5fdb374aa0edf102a14a

@k8s-ci-robot k8s-ci-robot merged commit 089d6ee into kubernetes:main Dec 2, 2021
@sftim sftim deleted the 20211016_revise_dynamic_kubelet_config_task branch December 8, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehabhalodiya mehabhalodiya mehabhalodiya left review comments

@RinkiyaKeDad RinkiyaKeDad RinkiyaKeDad left review comments

@mtaufen mtaufen Awaiting requested review from mtaufen

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@mehabhalodiya mehabhalodiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sftim @kbhawkey @k8s-ci-robot @RinkiyaKeDad @mehabhalodiya