Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark EphemeralContainers as GA in 1.25 #35545

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

verb
Copy link
Contributor

@verb verb commented Jul 29, 2022

This PR updates the website to reflect ephemeral containers graduating to GA.

Checklist before review:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 29, 2022
@netlify
Copy link

netlify bot commented Jul 29, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 3ad2a78
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62eacbe804076a00083f473c

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jul 29, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 29, 2022
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early feedback/

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 30, 2022
@verb verb changed the title PLACEHOLDER: Mark EphemeralContainers as GA in 1.25 Mark EphemeralContainers as GA in 1.25 Jul 30, 2022
@verb verb marked this pull request as ready for review July 30, 2022 14:55
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2022
@verb
Copy link
Contributor Author

verb commented Jul 30, 2022

@sftim There's more out of sync with api-reference than just ephemeral containers, so I think this must be updated all at once as part of the release process and I've only updated the section heading here.

Nothing else changed for ephemeral containers this release, so I think this is ready for review.

@divya-mohan0209 divya-mohan0209 added this to the 1.25 milestone Jul 31, 2022
@sftim
Copy link
Contributor

sftim commented Jul 31, 2022

We update generated reference docs at release time.

I would make the change to api-ref-assets/config/fields.yaml in a separate PR. @feloy: are there docs for how folks should update that file?

@feloy
Copy link
Member

feloy commented Aug 1, 2022

We update generated reference docs at release time.

I would make the change to api-ref-assets/config/fields.yaml in a separate PR. @feloy: are there docs for how folks should update that file?

@sftim This section of the README tries to document the process: https://github.com/kubernetes/website/blob/main/README.md#building-the-api-reference-pages

Running make api-reference makes some tips on the changes necessary to the files, but there is still some work to document it better

@verb
Copy link
Contributor Author

verb commented Aug 1, 2022

Just so I understand, why make api-ref-assets/config/fields.yaml changes in a separate PR? So the output is easier to review?

@feloy should I just run the api-reference update as part of the fields.yaml change in order to verify the fields.yaml change has the desired effect? Presumably it's not a problem if api-reference gets updated multiple times during the release process.

@feloy
Copy link
Member

feloy commented Aug 1, 2022

Just so I understand, why make api-ref-assets/config/fields.yaml changes in a separate PR? So the output is easier to review?

For the moment, we are used to create a single PR to update the fields.yaml/toc.yaml files and the generated Markdown pages, for example #29668

But the change done here about moving a field from Beta level to non-Beta level is difficult to catch afterwards, and for this reason I would prefer it is done in this specific PR, or you could create some issue for me to remember to do it as part of the global PR.

@feloy should I just run the api-reference update as part of the fields.yaml change in order to verify the fields.yaml change has the desired effect? Presumably it's not a problem if api-reference gets updated multiple times during the release process.

Yes, you would have to run the make api-reference command to generate the Markdown files that will be displayed in the website, to check the change is what you expect.

@feloy
Copy link
Member

feloy commented Aug 3, 2022

The change in fields.yaml is done in #35676

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 3, 2022
@reylejano
Copy link
Member

/assign @sethmccombs
/cc @kcmartin

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2022
@tengqm
Copy link
Contributor

tengqm commented Aug 18, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d86f9aed8c01847fabec13c11ddc0bb06551894e

@k8s-ci-robot k8s-ci-robot merged commit 438b426 into kubernetes:dev-1.25 Aug 18, 2022
@verb verb deleted the 1.25-ec-ga branch August 26, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants