Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: node: device manager graduation to GA #37466

Merged
merged 1 commit into from
Dec 11, 2022
Merged

blog: node: device manager graduation to GA #37466

merged 1 commit into from
Dec 11, 2022

Conversation

swatisehgal
Copy link
Contributor

@swatisehgal swatisehgal commented Oct 24, 2022 •
edited
Loading

Blog post for Device Manager graduation to GA.

Enhancement Issue: kubernetes/enhancements#3573

Signed-off-by: Swati Sehgal [email protected]

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 24, 2022
@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Oct 24, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 24, 2022
@swatisehgal
Copy link
Contributor Author

/sig node
/hold

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Oct 24, 2022
@netlify
Copy link

netlify bot commented Oct 24, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b1547df
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6390df8581dad40009c46731
😎 Deploy Preview https://deploy-preview-37466--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@swatisehgal swatisehgal mentioned this pull request Oct 24, 2022
Closed
4 tasks
@fsmunoz
Copy link
Contributor

fsmunoz commented Nov 22, 2022

Hello @swatisehgal , v1.26 Comms lead here. This feature blog is on a feature tracked for release, the deadline for submitting a draft is the 29th of November; this should be considered the hard limit since we will need to review/edit/discuss the draft, so if at all possible it's better to submit it earlier to avoid any problems.

Any doubts, we're here to help!

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 24, 2022
@swatisehgal swatisehgal force-pushed the devicemanager-ga-blog-post branch 2 times, most recently from 6221639 to aa172a1 Compare November 24, 2022 14:45
@ffromani
Copy link
Contributor

/cc

@swatisehgal swatisehgal changed the title [WIP] blog: node: device manager graduation to GA blog: node: device manager graduation to GA Nov 24, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2022
@swatisehgal swatisehgal force-pushed the devicemanager-ga-blog-post branch 2 times, most recently from 7d04981 to 4925716 Compare November 24, 2022 18:32
@fsmunoz
Copy link
Contributor

fsmunoz commented Nov 24, 2022

Hello @swatisehgal , with the recent commits do you think it's Ready for Review? Thanks!

@swatisehgal
Copy link
Contributor Author

Hello @swatisehgal , with the recent commits do you think it's Ready for Review? Thanks!

@fsmunoz Yes, the PR is ready for review. Thanks!

@swatisehgal
Copy link
Contributor Author

/unhold

@swatisehgal swatisehgal force-pushed the devicemanager-ga-blog-post branch 2 times, most recently from a0b3b87 to 47b9946 Compare November 29, 2022 09:46
@fsmunoz
Copy link
Contributor

fsmunoz commented Nov 30, 2022

Hello, Comms Lead for v1.26 here: this Feature Blog PR is confirmed for the post-release Feature Blog series. We will add the publishing date in the next days. Thank you for your work!

@fsmunoz
Copy link
Contributor

fsmunoz commented Dec 2, 2022

Hello, Comms Lead for v1.26 here. The publication order and date for the Feature Blog series has been finalised and the tracking board updated (cf. discussion).

The publication date for this article is 19-12-2022 (December 19).

Thanks!

@Debanitrkl
Copy link
Member

Hi, Comms Shadow for v1.26 here, since this has been properly reviewed and release dates added, approving it for final publication.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5dda72c70a7bcb99b70451cd64036de476b0d832

sftim
sftim reviewed Dec 7, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit more feedback.

/approve
/lgtm

I'd like to fix the path to the article at least.

content/en/blog/_posts/2022-11-21-devicemanager-ga.md/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-11-21-devicemanager-ga.md/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-11-21-devicemanager-ga.md/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-11-21-devicemanager-ga.md/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-11-21-devicemanager-ga.md/index.md Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2022
@sftim
Copy link
Contributor

sftim commented Dec 7, 2022

/hold
Do not unhold until Kubernetes 1.26 is released.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2022
@sftim
Copy link
Contributor

sftim commented Dec 8, 2022

Thanks again
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2e85978b327a85920136ad090d607ed7f69d33b3

@sftim
Copy link
Contributor

sftim commented Dec 11, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5c865a5 into kubernetes:main Dec 11, 2022
@swatisehgal swatisehgal deleted the devicemanager-ga-blog-post branch December 12, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@occase occase occase left review comments

@ffromani ffromani ffromani left review comments

@tengqm tengqm tengqm left review comments

@klueska klueska klueska left review comments

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@Debanitrkl Debanitrkl Awaiting requested review from Debanitrkl

@sftim sftim Awaiting requested review from sftim

Assignees

@sftim sftim

@Debanitrkl Debanitrkl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
SIG Node: code and documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@swatisehgal @fsmunoz @ffromani @Debanitrkl @k8s-ci-robot @sftim @klueska @tengqm @occase