Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blog post about binary artifact signing #37639

Merged
merged 1 commit into from
Dec 10, 2022
Merged

Add blog post about binary artifact signing #37639

merged 1 commit into from
Dec 10, 2022

Conversation

saschagrunert
Copy link
Member

Adding the placeholder PR for the feature blog post.

Refers to kubernetes/enhancements#3031

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 1, 2022
@saschagrunert saschagrunert mentioned this pull request Nov 1, 2022
Closed
7 tasks
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 1, 2022
@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Nov 1, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 1, 2022
@saschagrunert saschagrunert changed the title Add blog post about binary artifact signing WIP: Add blog post about binary artifact signing Nov 1, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2022
@fsmunoz
Copy link
Contributor

fsmunoz commented Nov 16, 2022

Hello @saschagrunert , v1.26 Comms lead here. This feature blog is on a feature tracked for release, the deadline for submitting a draft is the 29th of November; this should be considered the hard limit since we will need to review/edit/discuss the draft, so if at all possible it's better to submit it earlier to avoid any problems.

Any doubts, we're here to help!

@fsmunoz
Copy link
Contributor

fsmunoz commented Nov 29, 2022

Hello @saschagrunert, today is the Review Readiness deadline, without content the feature blog could be dropped - if there's anything we can do to help let us know.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 29, 2022
@saschagrunert saschagrunert force-pushed the artifact-sign-blog branch 5 times, most recently from b4a143f to 082f885 Compare November 29, 2022 11:47
@saschagrunert saschagrunert changed the title WIP: Add blog post about binary artifact signing Add blog post about binary artifact signing Nov 29, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2022
@saschagrunert
Copy link
Member Author

Ready for review. PTAL @kubernetes/release-engineering @kubernetes/sig-release-leads

@netlify
Copy link

netlify bot commented Nov 29, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c3ddd56
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6385ee80e466b00009735c8b
😎 Deploy Preview https://deploy-preview-37639--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 29, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 91183ff
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/638db0f09ffb95000844ff60
😎 Deploy Preview https://deploy-preview-37639--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

xmudrii
xmudrii reviewed Nov 29, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tiny nits, otherwise LGTM!

content/en/blog/_posts/2022-12-XX-kubernetes-release-artifact-signing.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-12-XX-kubernetes-release-artifact-signing.md Outdated Show resolved Hide resolved
xmudrii
xmudrii reviewed Nov 29, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more nit.

content/en/blog/_posts/2022-12-XX-kubernetes-release-artifact-signing.md Outdated Show resolved Hide resolved
xmudrii
xmudrii approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
/lgtm

@saschagrunert saschagrunert force-pushed the artifact-sign-blog branch 2 times, most recently from 4fad420 to 9fd0384 Compare November 30, 2022 09:00
@fsmunoz
Copy link
Contributor

fsmunoz commented Nov 30, 2022

Hello, Comms Lead for v1.26 here: this Feature Blog PR is confirmed for the post-release Feature Blog series. We will add the publishing date in the next days. Thank you for your work!

@saschagrunert saschagrunert force-pushed the artifact-sign-blog branch 2 times, most recently from 572e8c3 to cf412da Compare December 1, 2022 08:28
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 1, 2022
@saschagrunert saschagrunert force-pushed the artifact-sign-blog branch 2 times, most recently from 8caf2db to f0c09c1 Compare December 2, 2022 08:38
@fsmunoz
Copy link
Contributor

fsmunoz commented Dec 2, 2022

Hello, Comms Lead for v1.26 here. The publication order and date for the Feature Blog series has been finalised and the tracking board updated (cf. discussion).

The publication date for this article is 12-12-2022 (December 12).

Thanks!

sftim
sftim reviewed Dec 2, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions.
Changes since #37639 (review) are minor.

/lgtm
/approve
/hold

OK to unhold once the release has actually happened.

content/en/blog/_posts/2022-12-12-kubernetes-release-artifact-signing.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-12-12-kubernetes-release-artifact-signing.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-12-12-kubernetes-release-artifact-signing.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-12-12-kubernetes-release-artifact-signing.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-12-12-kubernetes-release-artifact-signing.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f539694a5ca0bcb171106b24582141146d5f78fe

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 2, 2022
@fsmunoz
Copy link
Contributor

fsmunoz commented Dec 7, 2022 •
edited
Loading

Marking this Ready for Publishing in Comms tracking, thank you for all the work - minor edits/reviews are still doable until the release publication date.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 497e67d505d25d95e3267dad49a3a87bed8e15b6

@sftim
Copy link
Contributor

sftim commented Dec 7, 2022

minor edits/reviews are still doable until the release date.

To clarify:
minor edits/reviews are still doable until the publication date for the article

We can make fixes afterwards, too, for up to 1 year. For example, to fix a typo. After 1 year we only update blog articles for special cases such as when the stale information could seriously mislead a reader.

@saschagrunert
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9d726dc into kubernetes:main Dec 10, 2022
@saschagrunert saschagrunert deleted the artifact-sign-blog branch December 10, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@onlydole onlydole Awaiting requested review from onlydole

@xmudrii xmudrii Awaiting requested review from xmudrii

@sftim sftim Awaiting requested review from sftim

Assignees

@fsmunoz fsmunoz

@xmudrii xmudrii

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saschagrunert @fsmunoz @k8s-ci-robot @sftim @xmudrii