Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add post-release blog article about Volume Group Snapshot alpha #39415

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Add post-release blog article about Volume Group Snapshot alpha #39415

merged 3 commits into from
Apr 26, 2023

Conversation

xing-yang
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2023
@xing-yang xing-yang mentioned this pull request Feb 12, 2023
Open
8 tasks
@netlify
Copy link

netlify bot commented Feb 12, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 4823101
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64495295bb18f60008856560
😎 Deploy Preview https://deploy-preview-39415--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sftim
Copy link
Contributor

sftim commented Feb 13, 2023

/retitle [WIP] Add post-release blog article about Volume Group Snapshot alpha

@k8s-ci-robot k8s-ci-robot changed the title Placeholder PR: Blog for Volume Group Snapshot [WIP] Add post-release blog article about Volume Group Snapshot alpha Feb 13, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2023
@bradmccoydev
Copy link
Member

Hello, Comms Shadow for the 1.27 release here. This feature blog is tracked for release, the deadline for submitting the draft is 4th of April- the sooner the better since there's still editing to be done afterward. Any doubt, the Comms team is here to help. Thanks!
/cc @harshitasao

@harshitasao
Copy link
Contributor

Hello @xing-yang, we're doing a global reminder about submitting a draft for review for all opted-in feature blogs. If it's at all possible, it is very helpful for the release team to have drafts submitted for review before the hard deadline date, to better plan the release dates and avoid missing out. Thank you!

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2023
@xing-yang xing-yang force-pushed the blog_VolumeGroupSnapshot branch 2 times, most recently from 6c30305 to d504daf Compare April 2, 2023 18:35
@xing-yang xing-yang changed the title [WIP] Add post-release blog article about Volume Group Snapshot alpha Add post-release blog article about Volume Group Snapshot alpha Apr 2, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2023
@xing-yang
Copy link
Contributor Author

Hi @harshitasao @bradmccoydev, the blog is ready for review. Thanks!

sftim
sftim reviewed Apr 3, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Some more feedback.

content/en/blog/_posts/2023-04-11-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-04-11-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-04-11-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-04-11-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-04-11-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-04-11-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-04-11-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-04-11-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-04-11-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-04-11-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
sftim
sftim reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
pending assignment of publication date

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2023
@harshitasao
Copy link
Contributor

Hello, Comms Lead for v1.27 here. The publication order and date for the Feature Blog series has been finalized and the tracking board is updated.

The publication date for this article is 08-05-2023 (May 08).

Thank you!

sftim
sftim reviewed Apr 9, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Here's some more feedback. I hope it all makes sense without more context; please feel to ask though if something I've suggested isn't obvious about why I did.

content/en/blog/_posts/2023-05-08-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-05-08-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-05-08-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-05-08-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-05-08-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-05-08-volume-group-snapshot-alpha.md Show resolved Hide resolved
content/en/blog/_posts/2023-05-08-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-05-08-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-05-08-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-05-08-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
@xing-yang
Copy link
Contributor Author

/assign @msau42

tengqm
tengqm reviewed Apr 12, 2023
View reviewed changes
Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
LGTM from docs, with a few nits.

content/en/blog/_posts/2023-05-08-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-05-08-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-05-08-volume-group-snapshot-alpha.md Show resolved Hide resolved
content/en/blog/_posts/2023-05-08-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2023
stmcginnis
stmcginnis reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a couple comments in case you do an update, but nothing I think is too critical.

content/en/blog/_posts/2023-05-08-volume-group-snapshot-alpha.md Show resolved Hide resolved
content/en/blog/_posts/2023-05-08-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-05-08-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-05-08-volume-group-snapshot-alpha.md Outdated Show resolved Hide resolved
@tengqm
Copy link
Contributor

tengqm commented Apr 26, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sftim
Copy link
Contributor

sftim commented Apr 26, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2023
sftim
sftim reviewed Apr 26, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 25d153890a2c5cfc25b292d642a306430e8dd429

@k8s-ci-robot k8s-ci-robot merged commit 770b345 into kubernetes:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcginnis stmcginnis stmcginnis left review comments

@tengqm tengqm tengqm left review comments

@sftim sftim sftim left review comments

@msau42 msau42 msau42 left review comments

@onlydole onlydole Awaiting requested review from onlydole

@harshitasao harshitasao Awaiting requested review from harshitasao

Assignees

@sftim sftim

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@xing-yang @sftim @bradmccoydev @harshitasao @tengqm @k8s-ci-robot @stmcginnis @msau42