Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc update for KEP-2896 OpenAPIV3 #40027

Merged
merged 4 commits into from
Apr 1, 2023
Merged

Doc update for KEP-2896 OpenAPIV3 #40027

merged 4 commits into from
Apr 1, 2023

Conversation

Jefftree
Copy link
Member

@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Mar 15, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2023
@Jefftree Jefftree mentioned this pull request Mar 15, 2023
Closed
13 tasks
@mickeyboxell
Copy link
Contributor

Hi @Jefftree 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review as soon as possible. 01:00 UTC Wednesday 22nd March 2023 / 17:00 PDT Tuesday 21st March 2023 is the official deadline.

This PR will need a doc review by Tuesday 4th April 2023 to get this into the release. Please reach out to required SIGs to get their review. Thank you!

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2023
@Jefftree Jefftree changed the title [WIP] Placeholder for doc update for KEP-2896 OpenAPIV3 Doc update for KEP-2896 OpenAPIV3 Mar 21, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 21, 2023
@Jefftree
Copy link
Member Author

/cc @apelisse @alexzielenski @seans3

apelisse
apelisse reviewed Mar 21, 2023
View reviewed changes
Copy link
Member

@apelisse apelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2023
@netlify
Copy link

netlify bot commented Mar 27, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 0c9ba63
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/642723c5ccde39000856a1e4

apelisse
apelisse reviewed Mar 27, 2023
View reviewed changes
Copy link
Member

@apelisse apelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment as I looked at it again :-) Thanks

content/en/docs/concepts/overview/kubernetes-api.md Outdated Show resolved Hide resolved
@tengqm
Copy link
Contributor

tengqm commented Apr 1, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6b159f9279353fb33b186fa65181a33010cdd936

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0faa93c into kubernetes:dev-1.27 Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@apelisse apelisse apelisse left review comments

@alexzielenski alexzielenski Awaiting requested review from alexzielenski

@seans3 seans3 Awaiting requested review from seans3

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.27
Development

Successfully merging this pull request may close these issues.
5 participants
@Jefftree @mickeyboxell @tengqm @k8s-ci-robot @apelisse