Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add docs for StructuredAuthenticationConfig v1alpha1 #43397

Merged
merged 2 commits into from
Nov 28, 2023
Merged

add docs for StructuredAuthenticationConfig v1alpha1 #43397

merged 2 commits into from
Nov 28, 2023

Conversation

aramase
Copy link
Member

@aramase aramase commented Oct 10, 2023

@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Oct 10, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2023
@netlify
Copy link

netlify bot commented Oct 10, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 74caa0d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6564faa44918f200088cf672

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2023
@aramase aramase mentioned this pull request Oct 10, 2023
Open
41 tasks
@aramase
Copy link
Member Author

aramase commented Oct 10, 2023

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Oct 10, 2023
@katcosgrove
Copy link
Contributor

Hi, @aramase! v1.29 Docs Lead here. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023. Thank you!

@liggitt liggitt mentioned this pull request Nov 3, 2023
Open
@katcosgrove
Copy link
Contributor

Hi, @aramase! Just dropping by to remind you that the deadline for docs PRs to be ready for review is tomorrow, November 14. Is there anything we can help you with to get this PR ready?

@katcosgrove
Copy link
Contributor

As discussed in Slack, your extended deadline to have this PR ready for review is Thursday, 16 November

@aramase aramase force-pushed the aramase/d/kep_3331_v1alpha1_docs_v1.29 branch from de17655 to cf806ac Compare November 18, 2023 01:54
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2023
@aramase aramase force-pushed the aramase/d/kep_3331_v1alpha1_docs_v1.29 branch from cf806ac to 33ffa3e Compare November 18, 2023 01:57
@aramase aramase marked this pull request as ready for review November 18, 2023 01:57
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2023
@katcosgrove
Copy link
Contributor

Hi, @aramase! Kubernetes v1.29 Docs Lead here. Just a reminder that the deadline to have this PR reviewed and merged is Tuesday, 28 November. Let me know if you need any help!

CCing KEP owners: @enj @nabokihms

@stlaz
Copy link
Member

stlaz commented Nov 20, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Nov 20, 2023
@aramase aramase force-pushed the aramase/d/kep_3331_v1alpha1_docs_v1.29 branch from 33ffa3e to 9fcda95 Compare November 20, 2023 18:23
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 20, 2023
@aramase
Copy link
Member Author

aramase commented Nov 20, 2023

/assign enj

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2023
enj
enj suggested changes Nov 21, 2023
View reviewed changes
content/en/docs/reference/access-authn-authz/authentication.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/authentication.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/authentication.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/authentication.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/authentication.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/authentication.md Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/authentication.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/authentication.md Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/authentication.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/authentication.md Show resolved Hide resolved
@aramase aramase force-pushed the aramase/d/kep_3331_v1alpha1_docs_v1.29 branch from 9fcda95 to 01e6f31 Compare November 21, 2023 19:28
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2023
@katcosgrove
Copy link
Contributor

Hello @enj and @aramase! The deadline to have this PR merged is Tuesday, November 28. Enhancements that do not include required documentation may not be included in the release. Is there anything I can do to help get this ready to merge? Thanks!

@aramase
review feedback
74caa0d 
Signed-off-by: Anish Ramasekar <[email protected]>
@aramase aramase force-pushed the aramase/d/kep_3331_v1alpha1_docs_v1.29 branch from 4f7312c to 74caa0d Compare November 27, 2023 20:25
@enj
Copy link
Member

enj commented Nov 27, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 638b315497b87e5b36a31a3d9f3e2ccbaf826309

@katcosgrove
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: katcosgrove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7c2f5c4 into kubernetes:dev-1.29 Nov 28, 2023
6 checks passed
@aramase aramase deleted the aramase/d/kep_3331_v1alpha1_docs_v1.29 branch November 28, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj enj requested changes

@deads2k deads2k Awaiting requested review from deads2k

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
5 participants
@aramase @katcosgrove @stlaz @enj @k8s-ci-robot