Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.8] StatefulSet initialized annotation is now ignored. #4426

Merged
merged 1 commit into from
Aug 10, 2017

Conversation

enisoc
Copy link
Member

@enisoc enisoc commented Jul 20, 2017

ref kubernetes/kubernetes#41605

This is dependent on kubernetes/kubernetes#49251 merging. (Done)


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2017
@enisoc
Copy link
Member Author

enisoc commented Jul 25, 2017

This is now ready for review as kubernetes/kubernetes#49251 has merged.

/assign @foxish @kow3ns
/unassign @smarterclayton

@k8s-ci-robot k8s-ci-robot assigned foxish and kow3ns and unassigned smarterclayton Jul 25, 2017
@foxish
Copy link
Contributor

foxish commented Jul 25, 2017

/lgtm

Copy link
Contributor

@chenopis chenopis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one link URL change requested.

refer to the [Deleting StatefulSet Pods](/docs/tasks/manage-stateful-set/delete-pods/) task for
instructions on how to deal with them.
You can debug individual Pods in a StatefulSet using the
[Debugging Pods](/docs/user-guide/debugging-pods-and-replication-controllers/#debugging-pods) guide.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the link URL should be /docs/tasks/debug-application-cluster/debug-pod-replication-controller/.

@chenopis chenopis removed the request for review from steveperry-53 August 8, 2017 22:08
@chenopis
Copy link
Contributor

chenopis commented Aug 8, 2017

@enisoc If you can take care of the merge conflicts and change that one URL, I think this will be ready to merge.

@enisoc enisoc force-pushed the initialized-annotation branch 2 times, most recently from 09e78c8 to ed32ec9 Compare August 9, 2017 23:34
@enisoc
Copy link
Member Author

enisoc commented Aug 9, 2017

Updated URL and rebase.

@chenopis chenopis merged commit aeb25d0 into kubernetes:release-1.8 Aug 10, 2017
@enisoc enisoc deleted the initialized-annotation branch August 10, 2017 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants