Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graduate HPAContainerMetrics to stable #45204

Merged
merged 1 commit into from
Mar 4, 2024
Merged

graduate HPAContainerMetrics to stable #45204

merged 1 commit into from
Mar 4, 2024

Conversation

sanposhiho
Copy link
Member

graduate HPAContainerMetrics to stable.
Part of kubernetes/enhancements#1610

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 19, 2024
@sanposhiho sanposhiho mentioned this pull request Feb 19, 2024
Closed
@netlify Netlify
Copy link

netlify bot commented Feb 19, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 98f0a91
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/65e2b32764fa52000800e5bc

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 19, 2024
@dipesh-rawat
Copy link
Member

/sig autoscaling

@k8s-ci-robot k8s-ci-robot added the sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. label Feb 19, 2024
@sanposhiho
Copy link
Member Author

@sftim @windsonsea Updated.
cc @gjtempleton from SIG/Autoscaling.

@sanposhiho
Copy link
Member Author

/assign @gjtempleton

sftim
sftim reviewed Feb 25, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://deploy-preview-45204--kubernetes-io-vnext-staging.netlify.app/docs/tasks/run-application/horizontal-pod-autoscale/#container-resource-metrics doesn't look right.

@sanposhiho would you be willing to:

  • rebase this on top of the tip of dev-1.30
  • squash to one commit

?

@sanposhiho
Copy link
Member Author

@sftim Sure, done.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 2, 2024
@gjtempleton
Copy link
Member

From a SIG point of view:
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f931ef9c4e2667248fee10f1a45ae50f1491c7ec

@sftim
Copy link
Contributor

sftim commented Mar 4, 2024

/lgtm
for docs

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit e9569b6 into kubernetes:dev-1.30 Mar 4, 2024
6 checks passed
@drewhagen
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Mar 15, 2024
@drewhagen
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@windsonsea windsonsea windsonsea left review comments

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees

@gjtempleton gjtempleton

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.30
Development

Successfully merging this pull request may close these issues.
7 participants
@sanposhiho @dipesh-rawat @gjtempleton @k8s-ci-robot @sftim @drewhagen @windsonsea