Redo code_sample shortcode #46362
Redo code_sample shortcode #46362
Conversation
k8s-ci-robot
added
area/web-development
k8s-ci-robot
added
cncf-cla: yes
sftim
force-pushed
the
20240514_redo_code_sample
branch
from
72622b0
to
7da67f6
Compare
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Use Hugo Pipes for the icon asset pipeline, and avoid inline styling.
Allow localizations to customize the tooltip for copying code samples to the clipboard.
sftim
force-pushed
the
20240514_redo_code_sample
branch
from
7da67f6
to
e2d9c4f
Compare
|
/area localization |
k8s-ci-robot
added
the
area/localization
There was a problem hiding this comment.
Nice improvements! Positive changes with Hugo pipes for images, localized strings, CSS improvement and potential RTL support in the future. Also, the changes render as expected in the preview page.
/lgtm
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: af05b0123864322cca8d73ccffcb070acae5f192
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Refactor shortcodes:
code_samplecodenew(legacy)code(legacy)and make the text localizable. The new approach uses Hugo Pipes to get the image, allowing further improvements such as image optimization at build time.
Also, add some padding around the icon (
secondthird commit).Example vs preview
/area web-development
This paves an easier path for right to left locale support.