Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include filename fix #5139

Merged
merged 3 commits into from
Sep 2, 2017
Merged

Include filename fix #5139

merged 3 commits into from
Sep 2, 2017

Conversation

mkuchin
Copy link
Contributor

@mkuchin mkuchin commented Aug 22, 2017

mysql-deployment.yaml was included instead of wordpress-deployment.yaml in the last step.


This change is Reviewable

mysql-deployment.yaml was included instead of wordpress-deployment.yaml in the last step.
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 22, 2017
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Aug 22, 2017

Deploy preview ready!

Built with commit 9626c72

https://deploy-preview-5139--kubernetes-io-master-staging.netlify.com

@chenopis chenopis requested a review from ahmetb August 22, 2017 00:59
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 22, 2017
@ahmetb
Copy link
Member

ahmetb commented Aug 22, 2017

/lgtm

@chenopis
Copy link
Contributor

@mkuchin Sorry, looks like there's a merge conflict now. Once you fix that, I can merge this PR. Thx

@chenopis
Copy link
Contributor

chenopis commented Sep 1, 2017

@mkuchin Ping.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 2, 2017
@chenopis chenopis merged commit 3c8a775 into kubernetes:master Sep 2, 2017
@mkuchin
Copy link
Contributor Author

mkuchin commented Sep 2, 2017

@chenopis I fixed merge conflict.

ChiuWang pushed a commit to ChiuWang/website that referenced this pull request Sep 4, 2017
* Include filename fix

mysql-deployment.yaml was included instead of wordpress-deployment.yaml in the last step.

* removing footer change kubernetes#5139
chenopis added a commit that referenced this pull request Sep 5, 2017
…hub.io into release-1.7

* 'master' of https://github.com/kubernetes/kubernetes.github.io:
  Update photon-controller.md (#5279)
  add back Zach and Steve to PR assignment
  fix the command output
  Update troubleshooting.md
  Update guaranteed-scheduling-critical-addon-pods.md
  Include filename fix (#5139)
  k8s-tutorials-stateful-application (#5112)
  Update gce.md (#5163)
  Update stage-documentation-changes.md (#5213)
  fix the command output
  Fix token-authentication-file internal link
chenopis added a commit that referenced this pull request Sep 5, 2017
…hub.io into release-1.8

* 'master' of https://github.com/kubernetes/kubernetes.github.io:
  Update photon-controller.md (#5279)
  add back Zach and Steve to PR assignment
  fix the command output
  Update troubleshooting.md
  Update guaranteed-scheduling-critical-addon-pods.md
  Include filename fix (#5139)
  k8s-tutorials-stateful-application (#5112)
  Update gce.md (#5163)
  Update stage-documentation-changes.md (#5213)
  fix the command output
  Fix token-authentication-file internal link
jesscodez pushed a commit that referenced this pull request Sep 22, 2017
* Include filename fix

mysql-deployment.yaml was included instead of wordpress-deployment.yaml in the last step.

* removing footer change #5139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants