Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubelet-config-file.md #7560

Closed
wants to merge 1 commit into from
Closed

Conversation

dgvigil
Copy link

@dgvigil dgvigil commented Feb 28, 2018

Updated the link from v1alpha1 to v1beta1

Updated the link from v1alpha1 to v1beta1
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: chenopis

Assign the PR to them by writing /assign @chenopis in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b9b4f19

https://deploy-preview-7560--kubernetes-io-master-staging.netlify.com

@mtaufen
Copy link
Contributor

mtaufen commented Feb 28, 2018

@dgvigil FYI there were a number of things that also needed to be updated, so I sent #7561. Thanks!

@mtaufen
Copy link
Contributor

mtaufen commented Feb 28, 2018

also noticed that the generated previews have FEATURE STATE: Kubernetes v1.9 at the top, when it should say FEATURE STATE: Kubernetes v1.10 for any docs changes for our next release...

Turns out this was because I was targeting the master branch instead of release-1.10 (still shows up as 1.9 in the preview, but this will be corrected in that branch).

@heckj
Copy link
Contributor

heckj commented Feb 28, 2018

@dgvigil if you haven't already, please sign the CLA so we can accept this update/patch. Is this specific to the release of 1.10, or relevant for the current version (v1.9)?

/assign

@mtaufen
Copy link
Contributor

mtaufen commented Mar 1, 2018

@heckj this is a dup of #7561, it can probably be closed (I don't have permissions).

@heckj
Copy link
Contributor

heckj commented Mar 1, 2018

closing as duplicate of #7561

@heckj heckj closed this Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants