remove show-all option description since it is now defaulted to true #7689
Conversation
It will be inert in 1.11 and removed in a future release. This patch fix related description on jobs doc. modified: docs/concepts/workloads/controllers/jobs-run-to-completion.md
k8s-ci-robot
added
cncf-cla: yes
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 57b4937 https://deploy-preview-7689--kubernetes-io-master-staging.netlify.com |
|
Overall this change looks very good to me. My only question is it worth adding a callout note mentioning that the show all option is no longer needed since it has been deprecated and defaulted to true. @zacharysarah Thoughts on this? |
|
@bradtopol we should remove any references to |
|
@bradtopol This sounds like a great candidate for the release notes rather than the docs. |
|
@zacharysarah: GitHub didn't allow me to request PR reviews from the following users: nickchase, WanLinghao. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I'd say both, actually. |
|
It's already in the release notes.
…---- Nick
On Friday, March 9, 2018, k8s-ci-robot ***@***.***> wrote:
@zacharysarah <https://github.com/zacharysarah>: GitHub didn't allow me
to request PR reviews from the following users: nickchase, WanLinghao.
Note that only kubernetes members
<https://github.com/orgs/kubernetes/people> and repo collaborators can
review this PR, and authors cannot review their own PRs.
In response to this
<#7689 (comment)>:
@bradtopol <https://github.com/bradtopol> This sounds like a great
candidate for the release notes rather than the docs.
/cc @WanLinghao <https://github.com/wanlinghao> @nickchase
<https://github.com/nickchase>
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/devel/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7689 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD0pwg1ZRHhiDHnVIa6_sGF3aDSxQPUGks5tcubkgaJpZM4SjxfJ>
.
|
|
@bradtopol @soltysh @zacharysarah thanks for your reply。I will do a thorough check |
|
should this be proposed against the release-1.10 branch? |
modified: docs/tasks/job/parallel-processing-expansion.md
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/S
|
I find other three places that have 2.https://kubernetes.io/docs/reference/generated/kubectl/kubectl-commands 3.https://kubernetes.io/docs/tasks/job/parallel-processing-expansion/ |
|
so..can anyone just approve this patch~ |
|
@WanLinghao please retarget the PR from the master branch to the release-1.10 branch. Getting close to cutoff so need @Bradamant3 input on what to do with this at this stage. Thank you again for your contribution |
|
Upon further investigation by @Bradamant3 we have already had two PRs submitted to fix this for 1.10 so I am going to close this. See #7574 Thank you. |
show-all is now defaulted to true and deprecated:
kubernetes/kubernetes#60210
It will be inert in 1.11 and removed in a future release.
This patch fix related description on jobs doc.