kubeadm-alpha: CoreDNS related changes #8727

neolit123 · 2018-05-24T17:27:29Z

Update note about CoreDNS feature gate.

This change also updates a tab as a kubeadm sub-command
will change.

It looks for a new generated file:
generated/kubeadm_alpha_phase_addon_coredns.md
instead of:
generated/kubeadm_alpha_phase_addon_kube-dns.md

Updates kubernetes/kubeadm#843

blocked by this PR against kubernetes/kubernetes:
kubernetes/kubernetes#64274

we need to fix the CLI first.

k8sio-netlify-preview-bot · 2018-05-24T17:27:32Z

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit 9a89523

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5b0871d73672df630b208c0d

neolit123 · 2018-05-24T17:27:36Z

/hold

neolit123 · 2018-05-24T17:28:29Z

/assign @Bradamant3

Bradamant3 · 2018-05-24T18:01:21Z

content/en/docs/reference/setup-tools/kubeadm/kubeadm-alpha.md

@@ -129,12 +129,13 @@ Alternatively, you can use [kubeadm config](kubeadm-config.md).
 You can install all the available addons with the `all` subcommand, or
 install them selectively.

-Please note that if kubeadm is invoked with `--feature-gates=CoreDNS=true`,  [CoreDNS](https://coredns.io/) is installed instead of `kube-dns`.
+In Kubernetes version 1.11 and later, the default DNS sever is [CoreDNS](https://coredns.io/).
+Please note that if `kubeadm` is invoked with `--feature-gates=CoreDNS=false`, kube-dns is installed instead of CoreDNS.


Let's format this a little differently, with a Hugo shortcode (putting inside code markup so you can see the rest of the markup properly):

{{< note >}} **Note:** If `kubeadm` is invoked with `--feature-gates=CoreDNS=false`, KubeDNS is installed. {{< /note >}}

(Text also trimmed bc we don't need the extra words :-) )

Bradamant3 · 2018-05-24T18:05:16Z

@kubernetes/sig-cluster-lifecycle-pr-reviews

I think I'm actually pretty on top of this one, but better to have another set of eyes inside the work.

neolit123 · 2018-05-24T18:19:06Z

thanks, updated.

mdlinville · 2018-05-24T23:13:43Z

I rebased this. PTAL and lgtm or approve as needed.

@neolit123 does this need a separate line in the feature-tracking spreadsheet from "Switch default DNS plugin to CoreDNS"?

neolit123 · 2018-05-24T23:45:26Z

@mistyhacks

does this need a separate line in the feature-tracking spreadsheet from "Switch default DNS plugin to CoreDNS"?

edit: that entry will suffice.
except that we have multiple kubernetes/website PRs for it and the docs are still WIP.

PR tracker issue:
kubernetes/kubeadm#843

tengqm · 2018-05-25T14:02:30Z

content/en/docs/reference/setup-tools/kubeadm/generated/kubeadm_alpha_phase_addon_coredns.md

@@ -0,0 +1,31 @@
+
+Installs the CoreDNS addon to a Kubernetes cluster


Please do not change this file manually. It is supposed to be generated automatically from upstream tools.

Update note about CoreDNS feature gate. This change also updates a tab as a kubeadm sub-command will change. It looks for a new generated file: generated/kubeadm_alpha_phase_addon_coredns.md instead of: generated/kubeadm_alpha_phase_addon_kube-dns.md

neolit123 · 2018-05-25T20:30:05Z

updated.

mdlinville · 2018-05-25T20:35:01Z

/approve

/assign @tengqm for lgtm

k8s-ci-robot · 2018-05-25T20:35:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mistyhacks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mistyhacks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mdlinville · 2018-05-25T20:35:18Z

/hold cancel

neolit123 · 2018-05-25T20:54:44Z

/hold

this needs to hold because the CLI is unclear, still:

blocked by this PR against kubernetes/kubernetes:
kubernetes/kubernetes#64274

neolit123 · 2018-05-29T01:22:40Z

can be merged / lgtm-ed now as this was merged:
kubernetes/kubernetes#64274

👍

/hold cancel

rajansandeep · 2018-05-29T15:14:56Z

/lgtm

Update note about CoreDNS feature gate. This change also updates a tab as a kubeadm sub-command will change. It looks for a new generated file: generated/kubeadm_alpha_phase_addon_coredns.md instead of: generated/kubeadm_alpha_phase_addon_kube-dns.md

* Seperate priority and preemption (#8144) * Doc about PID pressure condition. (#8211) * Doc about PID pressure condition. Signed-off-by: Da K. Ma <[email protected]> * "so" -> "too" * Update version selector for 1.11 * StorageObjectInUseProtection is GA (#8291) * Feature gate: StorageObjectInUseProtection is GA Update feature gate reference for 1.11 * Trivial commit to re-trigger Netlify * CRIContainerLogRotation is Beta in 1.11 (#8665) * Seperate priority and preemption (#8144) * CRIContainerLogRotation is Beta in 1.11 xref: kubernetes/kubernetes#64046 * Bring StorageObjectInUseProtection feature to GA (#8159) * StorageObjectInUseProtection is GA (#8291) * Feature gate: StorageObjectInUseProtection is GA Update feature gate reference for 1.11 * Trivial commit to re-trigger Netlify * Bring StorageObjectInUseProtection feature to GA StorageObjectInUseProtection is Beta in K8s 1.10. It's brought to GA in K8s 1.11. * Fixed typo and added feature state tags. * Remove KUBE_API_VERSIONS doc (#8292) The support to the KUBER_API_VERSIONS environment variable is completely dropped (no deprecation). This PR removes the related doc in release-1.11. xref: kubernetes/kubernetes#63165 * Remove InitialResources from admission controllers (#8293) The feature (was experimental) is dropped in 1.11. xref: kubernetes/kubernetes#58784 * Remove docs related to in-tree support to GPU (#8294) * Remove docs related to in-tree support to GPU The in-tree support to GPU is completely removed in release 1.11. This PR removes the related docs in release-1.11 branch. xref: kubernetes/kubernetes#61498 * Update content updated by PR to Hugo syntax Signed-off-by: Misty Stanley-Jones <[email protected]> * Update the doc about extra volume in kubeadm config (#8453) Signed-off-by: Xianglin Gao <[email protected]> * Update CRD Subresources for 1.11 (#8519) * coredns: update notes in administer-cluster/coredns.md (#8697) CoreDNS is installed by default in 1.11. Add notes on how to install kube-dns instead. Update notes about CoreDNS->CoreDNS upgrades as in 1.11 the Corefile is retained. Add example on upgrading from kube-dns to CoreDNS. * kubeadm-alpha: CoreDNS related changes (#8727) Update note about CoreDNS feature gate. This change also updates a tab as a kubeadm sub-command will change. It looks for a new generated file: generated/kubeadm_alpha_phase_addon_coredns.md instead of: generated/kubeadm_alpha_phase_addon_kube-dns.md * Update cloud controller manager docs to beta 1.11 (#8756) * Update cloud controller manager docs to beta 1.11 * Use Hugo shortcode for feature state * kubeadm-upgrade: include new command `kubeadm upgrade diff` (#8617) Also: - Include note that this was added in 1.11. - Modify the note about upgrade guidance. * independent: update CoreDNS mentions for kubeadm (#8753) Give CoreDNS instead of kube-dns examples in: - docs/setup/independent/create-cluster-kubeadm.md - docs/setup/independent/troubleshooting-kubeadm.md * update 1.11 --server-print info (#8870) * update 1.11 --server-print info * Copyedit * Mark ExpandPersistentVolumes feature to beta (#8778) * Update version selector for 1.11 * Mark ExpandPersistentVolumes Beta xref: kubernetes/kubernetes#64288 * fix shortcode, add placeholder files to fix deploy failures (#8874) * declare ipvs ga (#8850) * kubeadm: update info about CoreDNS in kubeadm-init.md (#8728) Add info to install kube-dns instead of CoreDNS, as CoreDNS is the default DNS server in 1.11. Add notes that kubeadm config images can be used to list and pull the required images in 1.11. * kubeadm: update implementation-details.md about CoreDNS (#8829) - Replace examples from kube-dns to CoreDNS - Add notes about the CoreDNS feature gate status in 1.11 - Add note that the service name for CoreDNS is also called `kube-dns` * Update block device support for 1.11 (#8895) * Update block device support for 1.11 * Copyedits * Fix typo 'fiber channel' (#8957) Signed-off-by: Misty Stanley-Jones <[email protected]> * kubeadm-upgrade: add the 'node [config]' sub-command (#8960) - Add includes for the generated pages - Include placeholder generated pages * kubeadm-init: update the example for the MasterConfiguration (#8958) - include godocs link for MasterConfiguration - include example MasterConfiguration - add note that `kubeadm config print-default` can be used * kubeadm-config: include new commands (#8862) Add notes and includes for these new commands in 1.11: - kubeadm config print-default - kubeadm config migrate - kubeadm config images list - kubeadm config images pull Include placeholder generated files for the above. * administer-cluster/coredns: include more changes (#8985) It was requested that for this page a couple of methods should be outlined: - manual installation for CoreDNS explained at the Kubernetes section of the GitHub project for CoreDNS - installation and upgrade via kubeadm Make the above changes and also add a section "About CoreDNS". This commit also lowercases a section title. * Update CRD subresources doc for 1.11 (#8918) * Add docs for volume expansion and online resizing (#8896) * Add docs for volume expansion going beta * Copyedit * Address feedback * Update exec plugin docs with TLS credentials (#8826) * Update exec plugin docs with TLS credentials kubernetes/kubernetes#61803 implements TLS client credential support for 1.11. * Copyedit * More copyedits for clarification * Additional copyedit * Change token->credential * NodeRestriction admission prevents kubelet taint removal (#8911) * dns-custom-namerserver: break down the page into mutliple sections (#8900) * dns-custom-namerserver: break down the page into mutliple sections This page is currently about kube-dns and is a bit outdated. Introduce the heading `# Customizing kube-dns`. Introduce a separate section about CoreDNS. * Copyedits, fix headings for customizing DNS Hey Lubomir, I coypedited pretty heavily because this workflow is so much easier for docs and because I'm trying to help improve everything touching kubeadm as much as possible. But there's one outstanding issue wrt headings and intro content: you can't add a heading 1 to a topic to do what you wanted to do. The page title in the front matter is rendered as a heading 1 and everything else has to start at heading 2. (We still need to doc this better in the docs contributing content, I know.) Instead, I think we need to rewrite the top-of-page intro content to explain better the relationship between kube-dns and CoreDNS. I'm happy to write something, but I thought I'd push this commit first so you can see what I'm doing. Hope it's all clear -- ping here or on Slack with any questions ~ Jennifer * Interim fix for talking about CoreDNS * Fix CoreDNS details * PSP readOnly hostPath (#8898) * Add documentation for crictl (#8880) * Add documentation for crictl * Copyedit Signed-off-by: Misty Stanley-Jones <[email protected]> * Final copyedit * VolumeSubpathEnvExpansion alpha feature (#8835) * Note that Heapster is deprecated (#8827) * Note that Heapster is deprecated This notes that Heapster is deprecated, and migrates the relevant docs to talk about metrics-server or other solutions by default. * Copyedits and improvements Signed-off-by: Misty Stanley-Jones <[email protected]> * Address feedback * fix shortcode to troubleshoot deploy (#9057) * update dynamic kubelet config docs for v1.11 (#8766) * update dynamic kubelet config docs for v1.11 * Substantial copyedit * Address feedback * Reference doc for kubeadm (release-1.11) (#9044) * Reference doc for kubeadm (release-1.11) * fix shortcode to troubleshoot deploy (#9057) * Reference doc for kube-components (release-1.11) (#9045) * Reference doc for kube-components (release-1.11) * Update cloud-controller-manager.md * fix shortcode to troubleshoot deploy (#9057) * Documentation on lowercasing kubeadm init apiserver SANs (#9059) * Documentation on lowercasing kubeadm init apiserver SANs * fix shortcode to troubleshoot deploy (#9057) * Clarification in dynamic Kubelet config doc (#9061) * Promote sysctls to Beta (#8804) * Promote sysctls to Beta * Copyedits Signed-off-by: Misty Stanley-Jones <[email protected]> * Review comments * Address feedback * More feedback * kubectl reference docs for 1.11 (#9080) * Update Kubernetes API 1.11 ref docs (#8977) * Update v1alpha1 to v1beta1. * Adjust left nav for 1.11 ref docs. * Trim list of old ref docs. * Update Federation API ref docs for 1.11. (#9064) * Update Federation API ref docs for 1.11. * Add titles. * Update definitions.html * CRD versioning Public Documentation (#8834) * CRD versioning Public Documentation * Copyedit Signed-off-by: Misty Stanley-Jones <[email protected]> * Address feedback * More rewrites * Address feedback * Update main CRD page in light of versioning * Reorg CRD docs * Further reorg * Tweak title * CSI documentation update for raw block volume support (#8927) * CSI documetation update for raw block volume support * minor edits for "CSI raw block volume support" Some small grammar and style nits. * minor CSIBlockVolume edits * Update kubectl component ref page for 1.11. (#9094) * Update kubectl component ref page for 1.11. * Add title. Replace stevepe with username. * crd versioning doc: fix nits (#9142) * Update `DynamicKubeletConfig` feature to beta (#9110) xref: kubernetes/kubernetes#64275 * Documentation for dynamic volume limits based on node type (#8871) * add cos for storage limits * Update docs specific for aws and gce * fix some minor things * Update storage-limits.md * Add k8s version to feature-state shortcode * The Doc update for ScheduleDaemonSetPods (#8842) Signed-off-by: Da K. Ma <[email protected]> * Update docs related to PersistentVolumeLabel admission control (#9109) The said admission controller is disabled by default in 1.11 (kubernetes/kubernetes#64326) and scheduled to be removed in future release. * client exec auth: updates for 1.11 (#9154) * Updates HA kubeadm docs (#9066) * Updates HA kubeadm docs Signed-off-by: Chuck Ha <[email protected]> * kubeadm HA - Add stacked control plane steps * ssh instructions and some typos in the bash scripts Signed-off-by: Chuck Ha <[email protected]> * Fix typos and copypasta errors * Fix rebase issues * Integrate more changes Signed-off-by: Chuck Ha <[email protected]> * copyedits, layout and formatting fixes * final copyedits * Adds a sanity check for load balancer connection Signed-off-by: Chuck Ha <[email protected]> * formatting fixes, copyedits * fix typos, formatting * Document the Pod Ready++ feature (#9180) Closes: #9107 Xref: kubernetes/kubernetes#64057 * Mention 'KubeletPluginsWatcher' feature (#9177) * Mention 'KubeletPluginsWatcher' feature This feature is more developers oriented than users oriented, so simply mention it in the feature gate should be fine. In future, when the design doc is migrated from Google doc to the kubernetes/community repo, we can add links to it for users who want to dig deeper. Closes: #9108 Xref: kubernetes/kubernetes#63328, kubernetes/kubernetes#64605 * Copyedit * Amend dynamic volume list docs (#9181) The dynamic volume list feature has been documented but the feature gate related was not there yet. Closes: #9105 * Document for service account projection (#9182) This adds docs for the service account projection feature. Xref: kubernetes/kubernetes#63819, kubernetes/community#1973 Closes: #9102 * Update pod priority and preemption user docs (#9172) * Update pod priority and preemption user docs * Copyedit * Documentation on setting node name with Kubeadm (#8925) * Documentation on setting node name with Kubeadm * copyedit * Add kubeadm upgrade docs for 1.11 (#9089) * Add kubeadm upgrade docs for 1.11 * Initial docs review feedback * Add 1-11 to outline * Fix formatting on tab blocks * Move file to correct location * Add `kubeadm upgrade node config` step * Overzealous ediffing * copyedit, fix lists and headings * clarify --force flag for fixing bad state * Get TOML ready for 1.11 release * Blog post for 1.11 release (#9254) * Blog post for 1.11 release * Update 2018-06-26-kubernetes-1.11-release-announcement.md * Update 2018-06-26-kubernetes-1.11-release-announcement.md * Update 2018-06-26-kubernetes-1.11-release-announcement.md

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 24, 2018

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 24, 2018

k8s-ci-robot requested review from bradtopol and tengqm May 24, 2018 17:27

k8s-ci-robot assigned Bradamant3 May 24, 2018

neolit123 mentioned this pull request May 24, 2018

document "CoreDNS by default in v1.11" kubernetes/kubeadm#843

Closed

11 tasks

Bradamant3 reviewed May 24, 2018

View reviewed changes

Bradamant3 added the Needs Tech Review label May 24, 2018

k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label May 24, 2018

Bradamant3 added this to the 1.11 milestone May 24, 2018

neolit123 force-pushed the coredns-kubeadm-alpha branch from bcd8a1d to 21f1ad1 Compare May 24, 2018 18:18

mdlinville force-pushed the release-1.11 branch from 5647835 to 8594900 Compare May 24, 2018 20:43

mdlinville force-pushed the coredns-kubeadm-alpha branch from 21f1ad1 to f9aead3 Compare May 24, 2018 23:11

mdlinville mentioned this pull request May 24, 2018

kubeadm: update info about CoreDNS in kubeadm-init.md #8728

Merged

tengqm requested changes May 25, 2018

View reviewed changes

neolit123 force-pushed the coredns-kubeadm-alpha branch from f9aead3 to 0f4e042 Compare May 25, 2018 20:08

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 25, 2018

neolit123 force-pushed the coredns-kubeadm-alpha branch from 0f4e042 to c8b1ab8 Compare May 25, 2018 20:26

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 25, 2018

neolit123 force-pushed the coredns-kubeadm-alpha branch from c8b1ab8 to b342e06 Compare May 25, 2018 20:26

neolit123 force-pushed the coredns-kubeadm-alpha branch from b342e06 to 9a89523 Compare May 25, 2018 20:28

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2018

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2018

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2018

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2018

k8s-ci-robot assigned rajansandeep May 29, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2018

k8s-ci-robot merged commit 20b6086 into kubernetes:release-1.11 May 29, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kubeadm-alpha: CoreDNS related changes #8727

kubeadm-alpha: CoreDNS related changes #8727

neolit123 commented May 24, 2018 •

edited

Loading

k8sio-netlify-preview-bot commented May 24, 2018 •

edited

Loading

neolit123 commented May 24, 2018

neolit123 commented May 24, 2018

Bradamant3 May 24, 2018

Bradamant3 commented May 24, 2018

neolit123 commented May 24, 2018

mdlinville commented May 24, 2018

neolit123 commented May 24, 2018 •

edited

Loading

tengqm May 25, 2018

neolit123 commented May 25, 2018

mdlinville commented May 25, 2018

k8s-ci-robot commented May 25, 2018

mdlinville commented May 25, 2018

neolit123 commented May 25, 2018

neolit123 commented May 29, 2018

rajansandeep commented May 29, 2018

		@@ -0,0 +1,31 @@

		Installs the CoreDNS addon to a Kubernetes cluster

kubeadm-alpha: CoreDNS related changes #8727

kubeadm-alpha: CoreDNS related changes #8727

Conversation

neolit123 commented May 24, 2018 • edited Loading

k8sio-netlify-preview-bot commented May 24, 2018 • edited Loading

neolit123 commented May 24, 2018

neolit123 commented May 24, 2018

Bradamant3 May 24, 2018

Choose a reason for hiding this comment

Bradamant3 commented May 24, 2018

neolit123 commented May 24, 2018

mdlinville commented May 24, 2018

neolit123 commented May 24, 2018 • edited Loading

tengqm May 25, 2018

Choose a reason for hiding this comment

neolit123 commented May 25, 2018

mdlinville commented May 25, 2018

k8s-ci-robot commented May 25, 2018

mdlinville commented May 25, 2018

neolit123 commented May 25, 2018

neolit123 commented May 29, 2018

rajansandeep commented May 29, 2018

neolit123 commented May 24, 2018 •

edited

Loading

k8sio-netlify-preview-bot commented May 24, 2018 •

edited

Loading

neolit123 commented May 24, 2018 •

edited

Loading