Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add video to case study index page #9941

Closed
wants to merge 2 commits into from
Closed

add video to case study index page #9941

wants to merge 2 commits into from

Conversation

alexcontini
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kbarnard10

If they are not already assigned, you can assign the PR to them by writing /assign @kbarnard10 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Aug 20, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit cbe26c5

https://deploy-preview-9941--kubernetes-io-master-staging.netlify.com

@zacharysarah
Copy link
Contributor

zacharysarah commented Aug 20, 2018

@alexcontini 👋 It looks like you need to update your local fork with today's changes (#9916). I recommend closing this PR, updating your local fork, then opening a new PR based on the refactored results.

To update your local fork of k/website:

git checkout master
git fetch upstream
git merge upstream/master
git push

@alexcontini
Copy link
Contributor Author

@zacharysarah thank you and sorry about that! so I see that it's been updated and is set up differently than before, I have been asked to add a video directly below the 4 featured case studies on the case study index page (https://www.youtube.com/embed/2RmJ32VqX3U) and can't quite understand how to/if this is possible to add?

are you or anyone on your team able to embed that video directly above the box video by any chance?

@zacharysarah
Copy link
Contributor

@alexcontini 👋 I'm at a conference this week, thanks for being patient. Are you trying to replace the "Kubernetes at Box" video?

@kbarnard10
Copy link
Contributor

@alexcontini - Sorry, just saw this. Let's chat more about this tomorrow!

@zacharysarah
Copy link
Contributor

@kbarnard10 I'm interested in knowing more, also--I can see the video: param in content/en/case-studies/box/index.html, but it looks like the logic in layouts/case-studies/list.html may populate the video player based on the fact that there's only one case study with a video: attribute.

@bep, any input?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants