Merge pull request #634 from kubescape/feature/service-spec

Adding review path for the service
kubescape · Jul 25, 2024 · 1876df0 · 1876df0
2 parents 36ec064 + ef079e7
commit 1876df0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/rules/unauthenticated-service/raw.rego b/rules/unauthenticated-service/raw.rego
@@ -17,19 +17,18 @@ deny contains msga if {
 	service_name := service.metadata.name
 	has_unauthenticated_service(service_name, service.metadata.namespace, service_scan_result)
 
-	# Path to the service object
-	path := "spec"
-
 	msga := {
 		"alertMessage": sprintf("Unauthenticated service %v exposes %v", [service_name, wl.metadata.name]),
 		"alertScore": 7,
 		"fixPaths": [],
-		"reviewPaths": [path],
+		"reviewPaths": [],
 		"failedPaths": [],
 		"packagename": "armo_builtins",
 		"alertObject": {"k8sApiObjects": [wl]},
 		"relatedObjects": [
-			{"object": service},
+			{"object": service,
+			"reviewPaths": ["spec"],
+			},
 		],
 	}
 }

diff --git a/rules/unauthenticated-service/test/fail_service/expected.json b/rules/unauthenticated-service/test/fail_service/expected.json
@@ -45,10 +45,10 @@
             }
           }
         },
-        "reviewPaths": null
+        "reviewPaths": ["spec"]
       }
     ],
-    "reviewPaths": ["spec"],
+    "reviewPaths": [],
     "ruleStatus": ""
   }
 ]