Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative redirect for old socketslack location #179

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Nov 25, 2022

Description

Changes proposed in this pull request:

  • Fix relative redirect for old socketslack location

Unfortunately the redirect worked only without trailing /.
Also, this page could be visible for users, so I changed the content to be more user-friendly.

This PR fixes these issues.

Preview

Try both URLs

https://fix-redirect.botkube-docs-dcb.pages.dev/next/installation/socketslack/
https://fix-redirect.botkube-docs-dcb.pages.dev/next/installation/socketslack

Related issue(s)

#178

@pkosiec pkosiec added the bug Something isn't working label Nov 25, 2022
@pkosiec pkosiec added this to the v0.16.0 milestone Nov 25, 2022
@pkosiec pkosiec marked this pull request as ready for review November 25, 2022 11:35
@pkosiec pkosiec requested review from a team and PrasadG193 as code owners November 25, 2022 11:35
@pkosiec pkosiec requested review from mszostok and removed request for a team November 25, 2022 11:35
@pkosiec pkosiec merged commit 59a9417 into kubeshop:main Nov 25, 2022
@pkosiec pkosiec deleted the fix-redirect branch November 25, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants