Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add ai scan command for cluster scan #336

Merged
merged 1 commit into from
May 28, 2024
Merged

docs: add ai scan command for cluster scan #336

merged 1 commit into from
May 28, 2024

Conversation

vaijab
Copy link
Contributor

@vaijab vaijab commented May 28, 2024

Description

Part of https://github.com/kubeshop/botkube-cloud/issues/1062

Changes proposed in this pull request:

  • docs: add ai scan command for cluster scan

Testing

Related issue(s)

@vaijab vaijab requested review from PrasadG193 and a team as code owners May 28, 2024 06:51
@vaijab vaijab requested a review from pkosiec May 28, 2024 06:51
Copy link

cloudflare-workers-and-pages bot commented May 28, 2024

Deploying botkube-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e089c38
Status: ✅  Deploy successful!
Preview URL: https://bea0772a.botkube-docs-58l.pages.dev
Branch Preview URL: https://clusterscan.botkube-docs-58l.pages.dev

View logs

Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can sync the docs to the 1.11. As there are no breaking changes, we can release the new AI plugin for 1.11 too 👍 But we can also do it later, up to you.

@@ -69,6 +69,11 @@ Here are a few examples to get you started:
- `@Botkube ai what Botkube plugins are available to install? List all of them with one sentence description and link to the docs.`
- `@Botkube ai who's the Botkube maintainer?`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also list the cluster scan feature in the ## Features section?

@vaijab
Copy link
Contributor Author

vaijab commented May 28, 2024

All suggestions addressed @pkosiec

Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vaijab vaijab merged commit e06bae4 into main May 28, 2024
3 checks passed
@vaijab vaijab deleted the clusterscan branch May 28, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants