Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plugins to use our helper merge function #7

Merged
merged 7 commits into from
Jan 26, 2023
Merged

Update plugins to use our helper merge function #7

merged 7 commits into from
Jan 26, 2023

Conversation

mszostok
Copy link
Collaborator

@mszostok mszostok commented Jan 23, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Use pluginx funcs

Related issue(s)

Note

I didn't use my fork, I will do that for next PRs.

@mszostok mszostok added the enhancement New feature or request label Jan 23, 2023
@mszostok mszostok marked this pull request as ready for review January 25, 2023 10:14
@mszostok mszostok requested a review from a team as a code owner January 25, 2023 10:14
@mszostok mszostok requested a review from pkosiec January 25, 2023 10:14
@mszostok mszostok mentioned this pull request Jan 25, 2023
Closed
@mszostok
Copy link
Collaborator Author

I forgot to update the README.md, I will address that after first review.

pkosiec
pkosiec reviewed Jan 25, 2023
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I'll test it along with reading the blog post and post a final approval 👍

go.mod Outdated Show resolved Hide resolved
pkosiec
pkosiec approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works really good!

.goreleaser.yaml Outdated Show resolved Hide resolved
.goreleaser.yaml Outdated Show resolved Hide resolved
@mszostok mszostok mentioned this pull request Jan 26, 2023
Merged
@mszostok
Copy link
Collaborator Author

mszostok commented Jan 26, 2023 •
edited
Loading

As discussed offline, the gh was moved under botkube repository: kubeshop/botkube#953

@mszostok mszostok merged commit 7118005 into main Jan 26, 2023
@mszostok mszostok deleted the add-gh-plugin branch January 26, 2023 17:02
@mszostok mszostok changed the title Add GitHub issue creator Update plugins to use our helper merge function Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @pkosiec