Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and validate plugin JSON schemas, produce second plugin index #1013

Merged
merged 12 commits into from
Mar 15, 2023

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Mar 9, 2023

Description

Changes proposed in this pull request:

  • Validate plugin JSON schemas
  • Produce second plugin index
  • Update JSON schemas

Testing

Run:

PLUGIN_DOWNLOAD_URL_BASE_PATH=http://localhost:64538/plugin-dist make gen-plugins-index
npx serve --listen 64538

Use http://localhost:64538/plugins-index.yaml as plugin repository and see the JSON schemas.

@pkosiec pkosiec added the enhancement New feature or request label Mar 9, 2023
@pkosiec pkosiec force-pushed the add-plugin-json-schema-validator branch from 5106ea7 to 6fe2e80 Compare March 9, 2023 13:00
@pkosiec pkosiec changed the title Validate plugin JSON schemas and produce second plugin index Update and validate plugin JSON schemas, produce second plugin index Mar 9, 2023
@pkosiec pkosiec force-pushed the add-plugin-json-schema-validator branch 8 times, most recently from 377e109 to 96c4870 Compare March 14, 2023 15:04
@pkosiec pkosiec marked this pull request as ready for review March 14, 2023 15:58
@pkosiec pkosiec requested review from a team and PrasadG193 as code owners March 14, 2023 15:58
@pkosiec pkosiec force-pushed the add-plugin-json-schema-validator branch from 96c4870 to 18b9f93 Compare March 14, 2023 15:58
Copy link
Contributor

@huseyinbabal huseyinbabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comment 🚀

@pkosiec
Copy link
Member Author

pkosiec commented Mar 15, 2023

Thank you @huseyinbabal for review 🙇 I'll wait for @josefkarasek as well as this PR is connected with the other one and want to make sure the schemas render fine before merge 👍

Copy link

@josefkarasek josefkarasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pkosiec pkosiec merged commit 02abb23 into kubeshop:main Mar 15, 2023
@pkosiec pkosiec deleted the add-plugin-json-schema-validator branch March 15, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants