Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable actions even if not bind to a specific channel #1014

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Enable actions even if not bind to a specific channel #1014

merged 2 commits into from
Mar 10, 2023

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Mar 9, 2023

Description

Changes proposed in this pull request:

  • Enable actions even if not bind to a specific channel

Testing

Covered by e2e tests.

Related issue(s)

Fix #1000

@mszostok mszostok added the bug Something isn't working label Mar 9, 2023
@mszostok mszostok marked this pull request as ready for review March 9, 2023 21:38
@mszostok mszostok requested review from a team and PrasadG193 as code owners March 9, 2023 21:38
@mszostok mszostok requested a review from pkosiec March 9, 2023 21:38
@pkosiec pkosiec self-assigned this Mar 10, 2023
pkosiec
pkosiec approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

internal/plugin/collector.go Show resolved Hide resolved
@mszostok mszostok enabled auto-merge (squash) March 10, 2023 12:50
@mszostok mszostok merged commit 8c300c7 into kubeshop:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees

@pkosiec pkosiec

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable plugin for actions
2 participants
@mszostok @pkosiec