Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote call for patching Actions #1017

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

josefkarasek
Copy link

Description

Add support for patching actions.

Testing

The remote call is not implemented in the backend - nothing to test.

Related issue(s)

https://github.com/kubeshop/botkube-cloud/issues/176

ResourceVersion: m.getResourceVersion(),
Action: &remoteapi.ActionPatchDeploymentConfigInput{
Name: name,
Enabled: &enabled,
Copy link
Contributor

@mszostok mszostok Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we have enabled where for notif we have disabled:

// ...
ChannelAlias:           channelAlias,
Disabled:               !enabled,

the forceconsistency is strong with this one 😅

@josefkarasek josefkarasek merged commit 040a4cb into kubeshop:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants