Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBAC e2e tests #1028

Merged
merged 13 commits into from
Mar 30, 2023
Merged

RBAC e2e tests #1028

merged 13 commits into from
Mar 30, 2023

Conversation

huseyinbabal
Copy link
Contributor

@huseyinbabal huseyinbabal commented Mar 29, 2023

Description

Changes proposed in this pull request:

Added e2e for RBAC for the following use cases

  • With no rbac config
  • With default rbac config
  • With static user/group mapping
  • With channel based mapping

Testing

Related issue(s)

Fixes #945

@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/vulnerability-scan.yml:scan-repo. As part of the setup process, we have scanned this repository and found 2 existing alerts. Please check the repository Security tab to see all alerts.

@huseyinbabal huseyinbabal force-pushed the rbac-e2e-tests branch 2 times, most recently from 14e105c to 0805d40 Compare March 29, 2023 13:41
@huseyinbabal huseyinbabal marked this pull request as ready for review March 30, 2023 12:45
@huseyinbabal huseyinbabal requested review from a team and PrasadG193 as code owners March 30, 2023 12:45
v13 "k8s.io/api/networking/v1"
v12 "k8s.io/api/rbac/v1"
v14 "k8s.io/client-go/kubernetes/typed/networking/v1"
v15 "k8s.io/client-go/kubernetes/typed/rbac/v1"
Copy link

@josefkarasek josefkarasek Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

netapiv1 etc would look better
rbacvapi1
netv1
rbacv1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed them, let's wait for tests

Copy link

@josefkarasek josefkarasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job handling dynamically generated channel names 👍

@josefkarasek josefkarasek merged commit 7873967 into kubeshop:main Mar 30, 2023
@huseyinbabal huseyinbabal deleted the rbac-e2e-tests branch March 30, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e tests coverage for plugins RBAC
2 participants