-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RBAC e2e tests #1028
RBAC e2e tests #1028
Conversation
You have successfully added a new Trivy configuration |
14e105c
to
0805d40
Compare
420b998
to
98edad3
Compare
test/e2e/bots_test.go
Outdated
v13 "k8s.io/api/networking/v1" | ||
v12 "k8s.io/api/rbac/v1" | ||
v14 "k8s.io/client-go/kubernetes/typed/networking/v1" | ||
v15 "k8s.io/client-go/kubernetes/typed/rbac/v1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
netapiv1
etc would look better
rbacvapi1
netv1
rbacv1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed them, let's wait for tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job handling dynamically generated channel names 👍
Description
Changes proposed in this pull request:
Added e2e for RBAC for the following use cases
Testing
Related issue(s)
Fixes #945