Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging heartbeat error and require providing Prometheus URL #1031

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Fix logging heartbeat error and require providing Prometheus URL #1031

merged 3 commits into from
Mar 31, 2023

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Mar 31, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Fix logging heartbeat error
  • Require providing Prometheus URL

@pkosiec pkosiec added the bug Something isn't working label Mar 31, 2023
@pkosiec pkosiec added this to the v0.19.0 milestone Mar 31, 2023
@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/vulnerability-scan.yml:scan-repo. As part of the setup process, we have scanned this repository and found 2 existing alerts. Please check the repository Security tab to see all alerts.

@pkosiec pkosiec changed the title Fix logging heartbeat error Fix logging heartbeat error and require providing Prometheus URL Mar 31, 2023
@pkosiec pkosiec marked this pull request as ready for review March 31, 2023 12:58
@pkosiec pkosiec requested review from a team and PrasadG193 as code owners March 31, 2023 12:58
@pkosiec pkosiec requested a review from mszostok March 31, 2023 12:58
mszostok
mszostok approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkosiec pkosiec enabled auto-merge (squash) March 31, 2023 13:04
@pkosiec pkosiec merged commit b703f14 into kubeshop:main Mar 31, 2023
@pkosiec pkosiec deleted the fix-reporting-heartbeat branch March 31, 2023 13:16
@pkosiec pkosiec mentioned this pull request Apr 3, 2023
Merged
huseyinbabal pushed a commit to huseyinbabal/botkube that referenced this pull request Apr 3, 2023
@pkosiec @huseyinbabal
Fix logging heartbeat error and require providing Prometheus URL (kub…
37bcc45 
…eshop#1031)

- Fix logging heartbeat error
- Require providing Prometheus URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Botkube
Status: Done
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pkosiec @mszostok