Respect Mattermost websocket subpath URLs #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever a subpath is passed on the Mattermost.URL, we should use the same path for its websocket connection string. Signed-off-by: Marcelo Mello <[email protected]>
|
@pkosiec I tested with the image ❯ kubectl get pods -w
NAME READY STATUS RESTARTS AGE
botkube-5474f55bc6-89x4t 2/2 Running 0 41s
❯ kubectl images
[Summary]: 1 namespaces, 1 pods, 2 containers and 2 different images
+--------------------------+-------------+----------------------------------------------------+
| Pod | Container | Image |
+--------------------------+-------------+----------------------------------------------------+
| botkube-5474f55bc6-89x4t | botkube | ghcr.io/kubeshop/pr/botkube:1040-PR |
+ +-------------+----------------------------------------------------+
| | cfg-watcher | ghcr.io/kubeshop/k8s-sidecar:ignore-initial-events |
+--------------------------+-------------+----------------------------------------------------+ |
pkosiec
pushed a commit
to pkosiec/botkube
that referenced
this pull request
May 11, 2023
Whenever a subpath is passed on the Mattermost.URL, we should use the same path for its websocket connection string. Signed-off-by: Marcelo Mello <[email protected]> (cherry picked from commit bd64d77)
pkosiec
pushed a commit
that referenced
this pull request
May 11, 2023
Whenever a subpath is passed on the Mattermost.URL, we should use the same path for its websocket connection string. Signed-off-by: Marcelo Mello <[email protected]> (cherry picked from commit bd64d77)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Whenever a subpath is passed on the Mattermost.URL, we should use the same path for its websocket connection string.
Testing
Related issue(s)
Fixes: #1037