Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging when executing a command in not configured channel #1061

Merged
merged 3 commits into from
May 12, 2023
Merged

Add logging when executing a command in not configured channel #1061

merged 3 commits into from
May 12, 2023

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented May 11, 2023

Description

Changes proposed in this pull request:

  • Rename IsAuthenticated to IsKnown
  • Add info logging when executing a command in not configured channel

Testing

Run Botkube locally and try to execute a command in a not configured channel. See the log.

Related issue(s)

Resolves #1059

@pkosiec pkosiec added the bug Something isn't working label May 11, 2023
@pkosiec pkosiec mentioned this pull request May 11, 2023
Closed
@pkosiec pkosiec changed the title Add debug logging when executing a command in not configured channel Add logging when executing a command in not configured channel May 11, 2023
@pkosiec pkosiec marked this pull request as ready for review May 11, 2023 15:38
@pkosiec pkosiec force-pushed the debug-log-unknown-conversation branch from f5b44f5 to c6ae43c Compare May 11, 2023 15:38
@pkosiec pkosiec requested review from a team and PrasadG193 as code owners May 11, 2023 15:38
@pkosiec pkosiec requested a review from huseyinbabal May 11, 2023 15:38
pkosiec
pkosiec commented May 12, 2023
View reviewed changes
pkg/execute/executor.go Outdated Show resolved Hide resolved
@huseyinbabal
Copy link
Contributor

@pkosiec is this something expected?
Screen Shot 2023-05-12 at 10 54 11
I see empty conversation id for not configured channel. Maybe I miss some scope on socket slack app

@pkosiec
Copy link
Member Author

pkosiec commented May 12, 2023

@huseyinbabal you're right, it was a bug - after testing it locally I wanted to improve the debug message with ID, but the ID is empty in such cases. Sorry for that, updated the log 👍

@huseyinbabal
Copy link
Contributor

@huseyinbabal you're right, it was a bug - after testing it locally I wanted to improve the debug message with ID, but the ID is empty in such cases. Sorry for that, updated the log 👍

No worries, approved now :) 🚀

@pkosiec pkosiec force-pushed the debug-log-unknown-conversation branch from d9f2ab8 to 668e504 Compare May 12, 2023 09:36
@pkosiec pkosiec enabled auto-merge (squash) May 12, 2023 09:37
@pkosiec pkosiec merged commit e601056 into kubeshop:main May 12, 2023
@pkosiec pkosiec deleted the debug-log-unknown-conversation branch May 12, 2023 10:04
pkosiec added a commit to pkosiec/botkube that referenced this pull request May 12, 2023
@pkosiec
Add logging when executing a command in not configured channel (kubes…
9cd0c1d 
…hop#1061)

* Add logging when executing a command in not configured channel
* Remove unused field from context

(cherry picked from commit e601056)
pkosiec added a commit that referenced this pull request May 12, 2023
@pkosiec
Add logging when executing a command in not configured channel (#1061)
0ab82b8 
* Add logging when executing a command in not configured channel
* Remove unused field from context

(cherry picked from commit e601056)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huseyinbabal huseyinbabal huseyinbabal approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hope to add more log for local debugging more easily
2 participants
@pkosiec @huseyinbabal