Add validation that kubeconfig is specified #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
force-pushed
the
validate-kc
branch
2 times, most recently
from
a91fc3b
to
ac04af7
Compare
pkosiec
approved these changes
May 12, 2023
pkosiec
approved these changes
May 12, 2023
pkosiec
approved these changes
May 12, 2023
pkosiec
pushed a commit
to pkosiec/botkube
that referenced
this pull request
May 12, 2023
(cherry picked from commit bf1d111)
pkosiec
pushed a commit
that referenced
this pull request
May 12, 2023
(cherry picked from commit bf1d111)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Testing
contextproperty forhelm,kcandk8splugins@Botkube helmor@Botkube kcIn the future, we should remove the internal logging and introduce an error feedback channel. Additionally, we can also consider posting errors on Slack/etc. Here we need to think whether post them directly or maybe introduce sth like
@Botkube check healthor sth similar.Some time ago it was also mentioned here: #878
Related issue(s)
Fix #1048