Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud gRPC Stream Integration #1083

Merged
merged 11 commits into from
Jun 8, 2023
Merged

Cloud gRPC Stream Integration #1083

merged 11 commits into from
Jun 8, 2023

Conversation

huseyinbabal
Copy link
Contributor

@huseyinbabal huseyinbabal commented Jun 6, 2023 •
edited
Loading

⚠️ Depends on https://github.com/kubeshop/botkube-cloud/pull/411 ⚠️

Description

Changes proposed in this pull request:

  • Export cloud environment variables as follows
export CONFIG_PROVIDER_IDENTIFIER=...
export CONFIG_PROVIDER_ENDPOINT=...
export CONFIG_PROVIDER_API_KEY=...
  • Run botkube application go run cmd/botkube/main.go
  • Now use some commands in your slack as follows
@BotkubeCloud ping <--replace bot name with yours
@BotkubeCloud edit sourcebindings
...

Testing

Related issue(s)

@huseyinbabal huseyinbabal mentioned this pull request Jun 6, 2023
Closed
@huseyinbabal huseyinbabal marked this pull request as ready for review June 7, 2023 06:32
@huseyinbabal huseyinbabal requested review from a team and PrasadG193 as code owners June 7, 2023 06:32
mszostok
mszostok reviewed Jun 7, 2023
View reviewed changes
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/bot/cloudslack.go Outdated Show resolved Hide resolved
mszostok
mszostok approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@huseyinbabal huseyinbabal merged commit 8de66eb into kubeshop:main Jun 8, 2023
@huseyinbabal huseyinbabal deleted the cloudslack-stream branch June 8, 2023 07:49
@josefkarasek josefkarasek added the enhancement New feature or request label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huseyinbabal @mszostok @josefkarasek