gRPC client auth added #1084
Merged
gRPC client auth added #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josefkarasek I've unassigned you from the review as I'll test both server + client changes E2E 👍 |
pkosiec
approved these changes
Jun 13, 2023
pkg/bot/cloudslack.go
Outdated
| @@ -92,7 +98,7 @@ func NewCloudSlack(log logrus.FieldLogger, | |||
|
|
|||
| func (b *CloudSlack) Start(ctx context.Context) error { | |||
| creds := grpc.WithTransportCredentials(insecure.NewCredentials()) | |||
| opts := []grpc.DialOption{creds} | |||
| opts := []grpc.DialOption{creds, grpc.WithStreamInterceptor(b.addCredentials())} | |||
There was a problem hiding this comment.
As suggested in the other PR, can you also include credentials in unary operations? Thanks!
Suggested change
| opts := []grpc.DialOption{creds, grpc.WithStreamInterceptor(b.addCredentials())} | |
| opts := []grpc.DialOption{creds, | |
| grpc.UnaryInterceptor(grpc_auth.UnaryServerInterceptor(b.addCredentials())), | |
| grpc.WithStreamInterceptor(b.addCredentials()), | |
| } |
pkosiec
reviewed
Jun 13, 2023
pkg/bot/cloudslack.go
Outdated
| return func(ctx context.Context, desc *grpc.StreamDesc, cc *grpc.ClientConn, method string, streamer grpc.Streamer, opts ...grpc.CallOption) (grpc.ClientStream, error) { | ||
| remoteCfg, ok := remote.GetConfig() | ||
| if !ok { | ||
| return nil, errors.New("while getting remote configuration") |
There was a problem hiding this comment.
Suggested change
| return nil, errors.New("while getting remote configuration") | |
| return nil, errors.New("empty remote configuration") |
|
slack e2e failed due to rate limit error, just re-ran the failed test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Testing
Better to test this together with https://github.com/kubeshop/botkube-cloud/pull/431
Related issue(s)