Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ServiceAccount token path in Config Watcher #1096

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Fix ServiceAccount token path in Config Watcher #1096

merged 2 commits into from
Jun 16, 2023

Conversation

huseyinbabal
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Config watcher docker image is updated and now helm chart uses up to date version
  • It contains fix for config watcher service token problem

Testing

Related issue(s)

@huseyinbabal huseyinbabal requested review from a team and PrasadG193 as code owners June 16, 2023 09:50
@pkosiec pkosiec requested review from pkosiec and removed request for mszostok June 16, 2023 09:54
@pkosiec pkosiec self-assigned this Jun 16, 2023
@pkosiec pkosiec added the bug Something isn't working label Jun 16, 2023
@pkosiec pkosiec changed the title in cluster config fixed for cfg watcher Fix ServiceAccount token path in Config Watcher Jun 16, 2023
pkosiec
pkosiec approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works flawlessly 👌 Thanks for spotting and fixing this issue!

@huseyinbabal huseyinbabal merged commit 2c8eb8c into kubeshop:main Jun 16, 2023
@huseyinbabal huseyinbabal deleted the cfg-watcher-in-cluster-config branch June 16, 2023 10:21
josefkarasek pushed a commit that referenced this pull request Jun 16, 2023
@huseyinbabal @mszostok
Release candidate No. 2 (#1097)
7140bd2 
* Fix ServiceAccount token path in Config Watcher (#1096)

* Implement retries for Start Cloud Slack func (#1095)

* Make sure that `kubectl` uses a proper kubeconfig (#1098)

---------

Co-authored-by: Hüseyin BABAL <[email protected]>
Co-authored-by: Mateusz Szostok <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees

@pkosiec pkosiec

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huseyinbabal @pkosiec