Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resetting retries when reconnecting to Cloud Slack #1101

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Jun 19, 2023

Description

Changes proposed in this pull request:

  • Fix resetting retries when reconnecting to Cloud Slack
  • Increase retries to 30, because why not

Testing

Connect to Cloud Slack, restart Slack router a few times, wait 3 minutes and see if the counter was resetted properly 👍

Proof:

obraz

@pkosiec pkosiec added the bug Something isn't working label Jun 19, 2023
@pkosiec pkosiec marked this pull request as ready for review June 19, 2023 08:26
@pkosiec pkosiec requested review from a team and PrasadG193 as code owners June 19, 2023 08:26
Copy link

@josefkarasek josefkarasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@josefkarasek josefkarasek merged commit 098c66d into kubeshop:main Jun 19, 2023
josefkarasek pushed a commit to josefkarasek/botkube that referenced this pull request Jun 19, 2023
josefkarasek pushed a commit that referenced this pull request Jun 19, 2023
…1101) (#1102)

Fix resetting retries when reconnecting to Cloud Slack (#1101)

Co-authored-by: Pawel Kosiec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants