Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated ptr pkg #1132

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Remove duplicated ptr pkg #1132

merged 1 commit into from
Jul 10, 2023

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Jul 9, 2023

Description

Changes proposed in this pull request:

  • Remove duplicated ptr pkg
  • Extract HTTP client, I will need it on my other PR

@mszostok mszostok added the bug Something isn't working label Jul 9, 2023
@mszostok mszostok added this to the v1.2.0 milestone Jul 9, 2023
@mszostok mszostok requested review from a team and PrasadG193 as code owners July 9, 2023 21:23
pkosiec
pkosiec approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't test it but CI ensures everything still works 👍

@mszostok mszostok merged commit 35007e4 into kubeshop:main Jul 10, 2023
@mszostok mszostok deleted the clean-up-ptr branch July 10, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

@huseyinbabal huseyinbabal Awaiting requested review from huseyinbabal huseyinbabal is a code owner automatically assigned from kubeshop/botkube-dev

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Botkube
Status: Done
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @pkosiec