Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint migration test #1159

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Lint migration test #1159

merged 2 commits into from
Jul 20, 2023

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Jul 20, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Lint migration test
  • Fix reported linter issues

@pkosiec pkosiec added the bug Something isn't working label Jul 20, 2023
@pkosiec pkosiec marked this pull request as ready for review July 20, 2023 08:30
@pkosiec pkosiec requested review from a team and PrasadG193 as code owners July 20, 2023 08:30
josefkarasek
josefkarasek approved these changes Jul 20, 2023
View reviewed changes
Copy link

@josefkarasek josefkarasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@pkosiec pkosiec merged commit 988389d into kubeshop:main Jul 20, 2023
@pkosiec pkosiec deleted the fix-migration-test2 branch July 20, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josefkarasek josefkarasek josefkarasek approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkosiec @josefkarasek