Keptn plugin added #1160
Merged
Keptn plugin added #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkosiec
reviewed
Jul 25, 2023
internal/source/keptn/client.go
Outdated
Comment on lines
10
to
35
| // Client Keptn client | ||
| type Client struct { | ||
| // API refers to Keptn client. https://github.com/keptn/go-utils | ||
| API *api.APISet | ||
| } | ||
|
|
||
| type GetEventsRequest struct { | ||
| Project string | ||
| FromTime time.Time | ||
| } | ||
|
|
||
| type Event struct { | ||
| ID string | ||
| Source string | ||
| Type string | ||
| Data Data | ||
| } | ||
|
|
||
| type Data struct { | ||
| Message string | ||
| Project string | ||
| Service string | ||
| Status string | ||
| Stage string | ||
| Result string | ||
| } |
There was a problem hiding this comment.
Please add comments to the structures. Thanks!
internal/source/keptn/client.go
Outdated
| data := Data{} | ||
| err := ev.DataAs(&data) | ||
| if err != nil { | ||
| return nil, err |
| log := loggerx.New(cfg.Log) | ||
| exitOnError(err, log) | ||
|
|
||
| for { |
There was a problem hiding this comment.
I think we should exit the for loop in case ctx.Done(). Please update this. Thank you!
Co-authored-by: Pawel Kosiec <[email protected]>
Co-authored-by: Pawel Kosiec <[email protected]>
Co-authored-by: Pawel Kosiec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Testing
You can refer to this article for testing. In that article I am explaining also howto implement plugin, but you don't need to implement it at all, only test.
Related issue(s)
#1089