Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim suffix for Mattermost URL #1168

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Trim suffix for Mattermost URL #1168

merged 3 commits into from
Jul 31, 2023

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Jul 31, 2023

Description

Changes proposed in this pull request:

  • Trim suffix for Mattermost URL

Testing

Related issue(s)

#1107

@pkosiec pkosiec added the bug Something isn't working label Jul 31, 2023
@pkosiec pkosiec marked this pull request as ready for review July 31, 2023 13:25
@pkosiec pkosiec requested review from a team and PrasadG193 as code owners July 31, 2023 13:25
@pkosiec pkosiec added this to the v1.3.0 milestone Jul 31, 2023
@pkosiec pkosiec merged commit b8e2b72 into kubeshop:main Jul 31, 2023
13 checks passed
@pkosiec pkosiec deleted the trim-suffix branch July 31, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huseyinbabal huseyinbabal huseyinbabal approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees

@huseyinbabal huseyinbabal

Labels
bug Something isn't working
Projects
Botkube
Status: Done
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pkosiec @huseyinbabal