Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform async message handling #1176

Merged

Conversation

huseyinbabal
Copy link
Contributor

@huseyinbabal huseyinbabal commented Aug 8, 2023

Description

Changes proposed in this pull request:

  • Added worker pool for asyn message handling

Testing

You can test Slack, Cloud Slack, Discord, and Mattermost as it is, they should all work. There is a 15 seconds delay in codebase, I will remove it before merge

Related issue(s)

Relates #1169

@huseyinbabal huseyinbabal changed the title socket slack message handling platform async message handling Aug 8, 2023
@@ -318,6 +344,7 @@ func (b *SocketSlack) handleMessage(ctx context.Context, event slackMessage) err
}

b.log.Debugf("Slack incoming Request: %s", request)
time.Sleep(time.Second * 15)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: remove this before merge.

@huseyinbabal huseyinbabal marked this pull request as ready for review August 9, 2023 15:12
@huseyinbabal huseyinbabal requested review from PrasadG193 and a team as code owners August 9, 2023 15:12
@mszostok mszostok added the bug Something isn't working label Aug 9, 2023
@mszostok mszostok self-assigned this Aug 9, 2023
pkg/bot/discord.go Show resolved Hide resolved
pkg/bot/mattermost.go Outdated Show resolved Hide resolved
pkg/bot/discord.go Outdated Show resolved Hide resolved
pkg/bot/discord.go Outdated Show resolved Hide resolved
pkg/bot/mattermost.go Outdated Show resolved Hide resolved
pkg/bot/discord.go Show resolved Hide resolved
pkg/bot/slack_cloud.go Outdated Show resolved Hide resolved
pkg/bot/slack_socket.go Outdated Show resolved Hide resolved
pkg/bot/slack_socket.go Outdated Show resolved Hide resolved
Copy link
Contributor

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@huseyinbabal huseyinbabal merged commit 710fefb into kubeshop:main Aug 10, 2023
13 checks passed
@huseyinbabal huseyinbabal deleted the async-platform-message-handling branch August 10, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants